Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: signed release for container image #3514

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Conversation

gaius-qi
Copy link
Member

Description

Related Issue

#3441

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@gaius-qi gaius-qi added the enhancement New feature or request label Sep 18, 2024
@gaius-qi gaius-qi added this to the v2.2.0 milestone Sep 18, 2024
@gaius-qi gaius-qi self-assigned this Sep 18, 2024
@gaius-qi gaius-qi requested a review from a team as a code owner September 18, 2024 06:07
Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.80%. Comparing base (759a70e) to head (16835e1).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3514      +/-   ##
==========================================
- Coverage   51.81%   51.80%   -0.02%     
==========================================
  Files         190      190              
  Lines       20377    20377              
==========================================
- Hits        10559    10556       -3     
- Misses       9014     9015       +1     
- Partials      804      806       +2     
Flag Coverage Δ
unittests 51.80% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

@gaius-qi gaius-qi force-pushed the feature/signed-release branch from 437972e to 678aa47 Compare September 18, 2024 06:23
@gaius-qi gaius-qi changed the title chore: signed release for containerd chore: signed release for container image Sep 18, 2024
@gaius-qi gaius-qi force-pushed the feature/signed-release branch from 678aa47 to 6caccb0 Compare September 18, 2024 06:41
chlins
chlins previously approved these changes Sep 18, 2024
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

yxxhero
yxxhero previously approved these changes Sep 18, 2024
@gaius-qi gaius-qi force-pushed the feature/signed-release branch from 844a6d7 to 16835e1 Compare September 18, 2024 06:50
@gaius-qi gaius-qi merged commit 8c0909a into main Sep 18, 2024
25 of 26 checks passed
@gaius-qi gaius-qi deleted the feature/signed-release branch September 18, 2024 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants