Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Word block matches make keywords disappear #70

Closed
aalvarado opened this issue Apr 3, 2018 · 4 comments
Closed

Word block matches make keywords disappear #70

aalvarado opened this issue Apr 3, 2018 · 4 comments

Comments

@aalvarado
Copy link
Contributor

aalvarado commented Apr 3, 2018

What happened

This plugin https://github.com/andymass/vim-matchup highlights matches, highlighting matches in the current theme version color is set to none for text color, if you jump to a method definition like def...end or if...endif these keywords will get lost in the background since both will have the same color.

What I expected to happen

correctly highlight matches.

commenting this line on line 321 sort of fixes it.

call s:h('MatchParen', s:none, s:pink, [s:attrs.underline])

but the color doesn't match the rest of the color scheme.

Screenshot

screen shot 2018-04-02 at 4 57 13 pm

commenting it:
screen shot 2018-04-02 at 4 59 24 pm

mvim 8.0, OSX.

@dsifford
Copy link
Member

dsifford commented Apr 3, 2018

Neat plugin!

Agree that this should probably be adjusted. Thanks for the report.

@dsifford
Copy link
Member

dsifford commented Apr 3, 2018

@aalvarado Thoughts on this?

image

image

@aalvarado
Copy link
Contributor Author

I really like it!

@aalvarado
Copy link
Contributor Author

thanks for patch, that was really fast!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants