Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need better installation instructions for Windows #244

Closed
benknoble opened this issue Apr 11, 2021 · 2 comments
Closed

Need better installation instructions for Windows #244

benknoble opened this issue Apr 11, 2021 · 2 comments

Comments

@benknoble
Copy link
Member

See this QA with a response from @romainl, who also points out a potential issue with our packadd! instructions. (They are necessary because of #138 #139 #140 #142.)

@romainl
Copy link

romainl commented Apr 13, 2021

So you managed to drag me into this after all…

You should move your palette variables from autoload/dracula.vim to colors/dracula.vim.

By doing that, you:

  • remove the dependency to autoload/dracula.vim from colors/dracula.vim,
  • so you don't need to have dracula in &rtp,
  • so you don't need packadd! dracula in your vimrc,
  • and you don't break the Airline and Lightline themes because the variables are defined long before they are sourced.

@benknoble
Copy link
Member Author

Sorry romainl; if you're not interested, I suppose you can unsubscribe. The airline issue arose when someone installed the colorscheme but did not activate it and attempted to activate the corresponding airline theme.

Do you have a better suggestion to avoid the duplication that doesn't involve the runtimepath? I suppose some <sfile>:h trickery might work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants