-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error & warning colors unreadable with coc plugin #191
Comments
I'm not a coc user. Thoughts @benknoble? |
@dsifford I’m meaning to look at the coc docs or code to identify the right highlight groups; we can decide then what to do? |
From their docs (assuming you're using neoclide/coc.nvim), there are a lot of highlight groups, and I'm not sure exactly which ones are which (I don't use coc, so I don't know what a "Read kind of document symbol" is...). @rtaibah could you experiment with some of these to at least identify which specific groups are causing your issue?
|
It's unfortunate the coc decided to hard-code the highlight colors for most of the groups, rather than just link them to the related groups so that themes wouldn't have to go back and set them all manually. Boo. |
These two are the ones causing them.
|
@rtaibah PRs accepted for this. See https://github.com/dracula/vim/blob/master/after/plugin/dracula.vim for an example of how (and where) we would do it for coc. Try to match the default PMenu highlight style if you can. |
Tried something like this:
Is not triggering anything. |
Try |
returns 1
returns 0 |
the second |
@dsifford Yeah, I was focusing on the first line. Still doesn't matter neither error or info are working. |
@rtaibah the variable appears to be Try that. https://github.com/neoclide/coc.nvim/blob/master/plugin/coc.vim#L48 |
And to be clear, you need to write it like this: if exists('g:did_coc_loaded') |
Just to make sure I am doing this right. I am using vim-plug and editing the file " CoC: {{{
if exists('g:did_coc_loaded')
hi! CocErrorSign ctermfg=blue guifg=#ff0000
hi! CocInfoSign ctermfg=black guifg=#fab005
endif
" }}} I exit vim with every edit to make sure the updated plugin is loaded. I expect the font color to change to either blue or black depending on whether its info or error. Am I missing anything? |
Try it without the condition. If that still doesn't work then it's not the condition causing the problem. |
Good call. Still not working. |
Then you probably have the wrong groups targeted. Try some of the others. Or just run the following and look for groups that match what you're trying to target.. :filter Coc hi |
The error sign is an emoji. You can't recolor that. |
My point is that group changed the text to green also. I’ll try other groups I guess. |
I opened an issue (quickly closed though lol) in the coc repo. Honestly I think that the Magenta default is pretty nice background for documentation and omni. However, when the documentation contains code or content which is |
Just reviewing, I wonder if @rtaibah's issue might be due to the way Coc colors--that is, @JDuchniewicz I'm not entirely sure I follow what your issue is, but I'd like to help fix it--can you give some examples/screenshots/more context/&c.? May be worth opening a separate issue. |
You can take a look at the issue linked above ( I think it is related though to this issue): |
Try this -
|
I have the same issue with "YouCompleteMe". Is there a solution for this problem ? |
@mukuntharajaa in general, we need to override the plugin's highlighting if it doesn't link to standard groups. Fortunately you can technically do this yourself (see If you can come up with customized highlights that fit with Dracula and solve YCM's problem, we'll probably accept a PR baking that in. Alternately, complain to YCM that their hard-coded highlighting is a poor strategy, and that they should link to standard groups instead :P |
What happened
Error & warning are very hard to read with coc plugin.
Screenshot
Machine Info
Darwin MacBook-Pro-5.local 18.7.0 Darwin Kernel Version 18.7.0: Thu Jan 23 06:52:12 PST 2020; root:xnu-4903.278.25~1/RELEASE_X86_64 x86_64
TERM
environment variable:Additional Info
The text was updated successfully, but these errors were encountered: