Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dracula Tilix #247

Closed
krzysztofzuraw opened this issue Oct 29, 2017 · 12 comments
Closed

Dracula Tilix #247

krzysztofzuraw opened this issue Oct 29, 2017 · 12 comments
Labels
✅ new theme New theme submission to be included in the organization

Comments

@krzysztofzuraw
Copy link
Member

krzysztofzuraw commented Oct 29, 2017

Theme for tilix
Repo: https://github.com/krzysztofzuraw/dracula-tilix
Screenshot:
screenshot

@jpitchardu
Copy link

I checked this, and it looks good, however, there are some colors that are not on the palette. May I suggest the use of the following palette:

"palette": [
        "#000000",
        "#FF5454",
        "#50FA7B",
        "#F1FA8C",
        "#BD93F9",
        "#FF79C6",
        "#8BE8FD",
        "#BFBFBF",
        "#4D4D4D",
        "#FF6E67",
        "#5AF78D",
        "#F4F99D",
        "#CAA8FA",
        "#FF92D0",
        "#9AEDFE",
        "#E6E6E6"
    ],

@krzysztofzuraw
Copy link
Member Author

@pichardoJ sure, changed in: dracula/tilix@79597ec

@jpitchardu
Copy link

@zenorocha Should this theme be added to the main repository?

@kendocode
Copy link

What needs to be done to get this into the main repo so it's easier to find? Could @krzysztofzuraw just submit a PR or is there another procedure?

Thanks for making this!

@hacknug
Copy link
Member

hacknug commented Jun 28, 2019

Someone mentioned in #318 that comments were hard to read when highlighted. Guess this would be the right place to discuss that?

@jpitchardu
Copy link

@hacknug Isn't that issue related to Vim rather than the emulator?

@hacknug hacknug added 🧭 needs readme Need to create or update theme documentation ✅ new theme New theme submission to be included in the organization labels Jul 2, 2019
@hacknug
Copy link
Member

hacknug commented Jul 2, 2019

Wow. Don't even know how this comment ended up here. it was supposed to go to #232 lol

Since we're here already, @krzysztofzuraw could you please update the repo's screenshot to reflect the changes made to the palette? Once that's done, I think we can move the repo to the organization 👍

@krzysztofzuraw
Copy link
Member Author

Updated - both repo and this issue screenshot

@krzysztofzuraw
Copy link
Member Author

@hacknug should I open PR with theme or you first need to create a new repo in org (via README)?

@hacknug
Copy link
Member

hacknug commented Jul 9, 2019

@krzysztofzuraw you need to trasfer it to the organization. Once it's been transfer I'll set the permissions so your team (aka @dracula/tilix) can push changes to the repo. Let me know once you've done it so I can do my part 👍

@hacknug hacknug added promote and removed 🧭 needs readme Need to create or update theme documentation labels Jul 9, 2019
@krzysztofzuraw
Copy link
Member Author

@hacknug
Copy link
Member

hacknug commented Jul 10, 2019

Just renamed the repo and set the right permissions so your team can push directly. Thank you so much for your contribution! 🎉

@hacknug hacknug closed this as completed Jul 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✅ new theme New theme submission to be included in the organization
Development

No branches or pull requests

4 participants