Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize colors for elements #192

Closed
nesl247 opened this issue May 30, 2016 · 10 comments
Closed

Standardize colors for elements #192

nesl247 opened this issue May 30, 2016 · 10 comments

Comments

@nesl247
Copy link

nesl247 commented May 30, 2016

Elements such as line numbers, the line number gutter, cursor, etc. should all have an official list of colors. It would also be help to have a preferred color for function names, class names, etc.

If an editor doesn't have the ability to choose the correct color, we'll have to deal with it (for instance PhpStorm is a bit weak when it comes to coloring specific tokens separately), however this will allow us to get as close as possible.

Once we have a full list, the current color palette will be renamed to "Base Color Palette" or something of the sort, with a new file linked in the README for a full color palette used for editors and IDEs.

Elements:

Element Hex RGB HSL
Line numbers
Line number gutter
Cursor
Code warnings
Code errors
*Doc Tags (eg. PhpDoc, JDoc)
Class name
Function name
Function visibility

If more elements are thought of I will add them to this list.

This was referenced May 30, 2016
@hackwaly
Copy link

hackwaly commented Aug 8, 2016

Request to add slight color element for highlight delimiters.

  • Delimiters of structured literal: { } [ ] , even "
  • OCaml quoted string {xml|xml text|xml}. It's better that highlight {xml| and |xml} in separated color.

I prefer using dark slight color for these to avoid distract users.

@ajitid
Copy link

ajitid commented May 18, 2017

Any update here? May 16 seems to be a long time 😕

@zenorocha
Copy link
Contributor

No updates here @ajitid, this change will affect all 38 themes, feel free to send a proposal if you're interested on this topic.

@dsifford
Copy link
Member

I'm interested in this topic. I'm going to start working on it (whenever time allows) here: dracula/visual-studio-code#12

I think that rather than tackling this across all 38 repos simultaneously, the only way to reasonably do it is to start with one "champion" repo to show that it can, in fact, be done (and done well).

Once it's all done in a single repo and documented out, that single repo would then send in an RFC to the main dracula repo and a discussion can be started about the color choices. I would expect this discussion to last a few months at least so that everybody's thoughts and ideas could be captured.

Anyway, that's what I'll likely do when time allows. So if you're interested in chiming in with thoughts @ajitid, feel free to do so there.

@zenorocha
Copy link
Contributor

Sounds like a great plan, thanks a lot @dsifford, you're rocking on the vscode theme! 🤘

@ajitid
Copy link

ajitid commented May 18, 2017

Thanks @dsifford!

@theevangelista
Copy link
Contributor

Some elements that may be common to most of languages that we could add to the list:

  • Strings
  • Parameters
  • Numbers

@dsifford
Copy link
Member

dsifford commented May 28, 2017

Finished the initial specification and implementation this morning. Gonna clean some stuff up and then PR create an issue with an RFC shortly.

@dsifford
Copy link
Member

RFC here: #232

@zenorocha
Copy link
Contributor

Closing in favor of #232

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

6 participants