Bug tcp invalid contact string #322
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge origin
Feature flexible localpublic ip
davehorton
requested changes
Dec 3, 2023
entrypoint.sh
Outdated
| @@ -33,6 +33,11 @@ case $CLOUD in | |||
| ;; | |||
| esac | |||
|
|
|||
There was a problem hiding this comment.
I dont think this change has anything to do with the stated issue, could it be removed from the PR
Dockerfile
Outdated
| @@ -2,7 +2,7 @@ FROM debian:bullseye-slim | |||
|
|
|||
| RUN apt-get update \ | |||
| && apt-get -y --quiet --force-yes upgrade \ | |||
| && apt-get install -y --no-install-recommends ca-certificates gcc g++ make build-essential cmake git autoconf automake curl libtool libtool-bin libssl-dev libcurl4-openssl-dev zlib1g-dev libgoogle-perftools-dev \ | |||
| && apt-get install -y --no-install-recommends ca-certificates gcc g++ make build-essential cmake git autoconf automake curl libtool libtool-bin libssl-dev libcurl4-openssl-dev zlib1g-dev libgoogle-perftools-dev iproute2 \ | |||
There was a problem hiding this comment.
prefer to remove changes from Dockerfile from this PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using TCP and REGISTER (or SUBSCRIBE) there is a problem with the contact string.
When a REGISTER occurs in sip-dialog-controller.cpp :1028 a session is registered - and UDP is excluded but TCP isn't. When a new INVITE is then sent out (sometime after the REGISTER).
sip-dialog-controller.cpp:443 enters the if statement. I have left the UDP check - however, it is superfluous as NULL is always passed in. But, because of the above test m_pController->findTportForSubscription will return for UDP but if there it TCP and a REGISTER has happened then it will return the session and set the contact string to the local IP.
This fix uses the proto to correct the contact string - but I am not 100% certain this is the correct way to fix this.
resolves #319