Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support additional_bindings #4

Open
dpup opened this issue Apr 19, 2024 · 1 comment
Open

Support additional_bindings #4

dpup opened this issue Apr 19, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@dpup
Copy link
Owner

dpup commented Apr 19, 2024

From grpc-ecosystem#32

The parser and generator should add support for methods with additional_bindings, allowing multiple different URLs to access the same gRPC endpoint. The current code only renders code for the outer method, but silently ignores the additional_bindings.

This is especially useful when you have bindings using different HTTP verbs, like PUT and PATCH, that hit the same gRPC method but may use different verbs, or populate different fields from the URL.

@dpup dpup added the enhancement New feature or request label Apr 19, 2024
@dpup
Copy link
Owner Author

dpup commented Apr 19, 2024

How should this work?

Should it generate multiple methods:

const resp = await Greeter.SayHello({ name });
const resp = await Greeter.SayHelloPost({ name });
const resp = await Greeter.SayHelloPut({ name });

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant