Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename GroupCoordinatorRequest to FindCoordinatorRequest #1630

Open
jeffwidman opened this issue Nov 12, 2018 · 3 comments
Open

Rename GroupCoordinatorRequest to FindCoordinatorRequest #1630

jeffwidman opened this issue Nov 12, 2018 · 3 comments
Milestone

Comments

@jeffwidman
Copy link
Collaborator

In Kafka 0.11, the GroupCoordinatorRequest / GroupCoordinatorResponse structs were renamed to FindCoordinatorRequest / FindCoordinatorResponese as part of KIP-98.

So the following need updating:

class GroupCoordinatorRequest_v1(Request):
API_KEY = 10
API_VERSION = 1
RESPONSE_TYPE = GroupCoordinatorResponse_v1
SCHEMA = Schema(
('coordinator_key', String('utf-8')),
('coordinator_type', Int8)
)

class GroupCoordinatorResponse_v1(Response):
API_KEY = 10
API_VERSION = 1
SCHEMA = Schema(
('error_code', Int16),
('error_message', String('utf-8')),
('coordinator_id', Int32),
('host', String('utf-8')),
('port', Int32)
)

This should be straightforward as currently the v1 version is not used by any of the code.

@jeffwidman
Copy link
Collaborator Author

See also #1641 (comment) where @dpkp noted:

I believe that v1 adds the idea of a group type. All groups I have seen are consumers, but I think Kafka Streams may use group coordination for producers or even other abstract groups. In any event, we'd need to add a parameter for group type I believe.

@jeffwidman jeffwidman added this to the 2.0 milestone Nov 19, 2018
@jeffwidman
Copy link
Collaborator Author

Added to 2.0 milestone because that would provide an opportunity to do this rename as a backwards incompatible change...

@tvoinarovskyi
Copy link
Collaborator

Lets rename it and just retain the old link to the new class for some time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants