Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: edit command is destructive #142

Closed
sedlund opened this issue Oct 6, 2023 · 3 comments
Closed

BUG: edit command is destructive #142

sedlund opened this issue Oct 6, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@sedlund
Copy link

sedlund commented Oct 6, 2023

when using edit it will remove all custom fields even if nothing is changed

rbw 1.8.3

$ rbw sync

$ rbw get --full snort.social
blah
Username: blah
URI: https://snort.social/new
private: mysecretkey

$ rbw edit snort.social
# opens nvim, I change nothing and :q

$ rbw get --full snort.social
blah
Username: blah
URI: https://snort.social/new
@mvaaltola
Copy link

I'm able to replicate this as well. The custom field is not included in the edit file which is probably why it disappears after editing. It seems rbw sends an update to the server even if changing nothing in the edit file and quitting with :q (password history increases). I would expect rbw to only send an update to the server if the edit file is saved and there are actual changes to the file.

@sedlund sedlund changed the title BUG: when using edit it will remove all custom fields even if nothing is changed BUG: edit command is destructive Jan 13, 2024
@kucharskim
Copy link

I just hit the same issue. Did not expect update will go to the server, when I did not change the file with rbw edit command.

@doy doy added the bug Something isn't working label Apr 20, 2024
@doy
Copy link
Owner

doy commented Apr 20, 2024

fixed in 1.10.0, thanks!

@doy doy closed this as completed Apr 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants