Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: Update/Remove prop-types Usage #1606

Open
joealden opened this issue May 28, 2024 · 0 comments · May be fixed by #1617
Open

Request: Update/Remove prop-types Usage #1606

joealden opened this issue May 28, 2024 · 0 comments · May be fixed by #1617

Comments

@joealden
Copy link

  • downshift version: 9.0.6
  • node version: 20.11.1
  • npm (or yarn) version: Yarn 4.2.2

Problem description:

I'm getting the following earning: "Failed prop type: The prop environment.document.activeElement is marked as required, but its value is null". As mentioned in https://developer.mozilla.org/en-US/docs/Web/API/Document/activeElement + the TS types, this value is nullable.

Suggested solution:

We could just update the relevant prop types to not have this marked as required, but looking at the bigger picture - do we still see value in providing prop types at all? Could these be removed in v10 (#1588)?

@silviuaavram silviuaavram linked a pull request Jul 26, 2024 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant