Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert js to use new global Garnish events #9

Closed
joshangell opened this issue Jul 11, 2018 · 3 comments
Closed

Convert js to use new global Garnish events #9

joshangell opened this issue Jul 11, 2018 · 3 comments
Assignees
@joshangell
Labels
Feature Request New feature or request

Comments

@joshangell
Copy link
Contributor

This should massively help with performance, and will hopefully remove the need to watch for resize events which I suspect is the issue with Safari (#8)
@joshangell joshangell self-assigned this Jul 11, 2018
@joshangell joshangell added the Feature Request New feature or request label Jul 11, 2018
@ricdev ricdev mentioned this issue Sep 13, 2018
Closed
@joshangell
Copy link
Contributor Author

joshangell commented Oct 12, 2018 •
edited
Loading

Needs this.trigger('beforeTypeChange'); adding Craft.EntryTypeSwitcher at line ~ 23 and the following in Craft.MatrixInput:

// Line ~ 124 (end of init)
this.trigger('afterInit');

// Line ~ 263
this.trigger('blockAdded', {
    data: {
        block: $block
    }
});

@joshangell
Copy link
Contributor Author

joshangell commented Oct 12, 2018 •
edited
Loading

Similar changes would need to be made in Super Table.

@joshangell
Copy link
Contributor Author

Craft is ready: craftcms/cms#3375

This was referenced Jan 10, 2019
Closed
Closed
@heymarkreeves heymarkreeves mentioned this issue Jan 31, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joshangell joshangell

Labels
Feature Request New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@joshangell