Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pyairports #1093

Closed
lapp0 opened this issue Aug 12, 2024 · 1 comment · Fixed by #1156
Closed

Remove pyairports #1093

lapp0 opened this issue Aug 12, 2024 · 1 comment · Fixed by #1156

Comments

@lapp0
Copy link
Contributor

lapp0 commented Aug 12, 2024

What behavior of the library made you think about the improvement?

We currently rely on a poorly maintained package, pyairports. The way this package is structured has caused a few build / test issues

The only use for pyairports in outlines is outlines.types.airports, in which we load AIRPORT_IATA_LIST. pyairports isn't maintained, so the list is presumably out of date.

How would you like it to behave?

We should remove the pyairports dependency and use a different package.

import airportsdata
IATA_CODES = sorted(airportsdata.load().keys())
@cpfiffer
Copy link
Contributor

Bump on this one. It's kind of an annoying issue, I often have to install setuptools and I believe it's the only package I need it for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants