Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling severe errors #368

Open
Tratcher opened this issue Aug 18, 2020 · 2 comments
Open

Handling severe errors #368

Tratcher opened this issue Aug 18, 2020 · 2 comments
Labels
Type: Bug Something isn't working
Milestone

Comments

@Tratcher
Copy link
Member

#357 (comment)

There are some severe error conditions that we need to come up with a consistent, extensible policy for addressing. Some examples:

  1. Fail to load config data at startup. Current behavior: throw with intent to crash the app.
  2. Fail to reload config data. Current behavior: Log and keep running with the last known good config. Some of these errors will prevent the proxy from listening for future config changes because IChangeToken is single use.

An application developer may want to FailFast the app or trigger a graceful shutdown in the case of a config reload failure, but app lifetime should be something controlled by the developer, not by the ReverseProxy library. We may need to provide extensibility points where the developer can handle these errors in their own way.

@Tratcher Tratcher added the Type: Bug Something isn't working label Aug 18, 2020
@karelz karelz added this to the 1.0.0 milestone Sep 8, 2020
@karelz
Copy link
Member

karelz commented Sep 8, 2020

Triage: We need to decide what is the right API/behavior. FailFast is likely not a good behavior.

@karelz karelz modified the milestones: YARP 1.0.0, Backlog Mar 29, 2021
@karelz
Copy link
Member

karelz commented Mar 29, 2021

Triage: This does not seem to be blocking @davidni (right?), moving to Backlog ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants