From d9522a427df98bf679b5cf656208358513eb6401 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Alexander=20K=C3=B6plinger?= Date: Fri, 27 Jun 2025 20:45:31 +0200 Subject: [PATCH 1/2] Remove firewall setting from copilot-setup-steps.yml This doesn't actually work as an env var, it needs to be set as a GitHub Actions variable in the repository settings. --- .github/workflows/copilot-setup-steps.yml | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/.github/workflows/copilot-setup-steps.yml b/.github/workflows/copilot-setup-steps.yml index e79803086..1a877525b 100644 --- a/.github/workflows/copilot-setup-steps.yml +++ b/.github/workflows/copilot-setup-steps.yml @@ -12,10 +12,6 @@ on: permissions: contents: read -env: - # Allow Copilot to access Visual Studio assets URLs needed for NuGet restore - COPILOT_AGENT_FIREWALL_ALLOW_LIST_ADDITIONS: "vsblob.vsassets.io" - jobs: copilot-setup-steps: @@ -31,4 +27,4 @@ jobs: - name: Check dotnet version run: | - dotnet --version \ No newline at end of file + dotnet --version From a130967182d5e5e5a36d0d29bb135c53be657b43 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Alexander=20K=C3=B6plinger?= Date: Fri, 27 Jun 2025 21:26:07 +0200 Subject: [PATCH 2/2] Only do a restore in copilot-setup-steps.yml to make sure a build error doesn't break Copilot --- .github/workflows/copilot-setup-steps.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/copilot-setup-steps.yml b/.github/workflows/copilot-setup-steps.yml index 1a877525b..352efa8fd 100644 --- a/.github/workflows/copilot-setup-steps.yml +++ b/.github/workflows/copilot-setup-steps.yml @@ -18,9 +18,9 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 - - name: Do an initial build to ensure all dependencies are restored + - name: Do an initial restore to ensure all dependencies are restored run: | - ./build.sh + ./eng/common/build.sh --restore - name: Put repo-local dotnet install on PATH run: | echo "PATH=$PWD/.dotnet:$PATH" >> $GITHUB_ENV