Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate DPI awareness initialization to managed #5765

Merged
merged 1 commit into from
Jan 3, 2022

Conversation

ThomasGoulet73
Copy link
Contributor

@ThomasGoulet73 ThomasGoulet73 commented Dec 1, 2021

Contributes #5305

Description

Migrate DPI awareness initialization to managed.

I removed the OS check used to only do the initialization on Windows Vista or later since every version of Windows supported by .Net 6 are more recent than Windows Vista, which renders the check unnecessary.

Customer Impact

None.

Regression

No.

Testing

I tested a WPF application with this PR with high DPI and the DPI awareness was initialized properly.

Risk

Seems pretty low.

@ThomasGoulet73 ThomasGoulet73 requested a review from a team as a code owner December 1, 2021 01:32
@ghost ghost added the PR metadata: Label to tag PRs, to facilitate with triage label Dec 1, 2021
@ghost ghost requested review from fabiant3, ryalanms and SamBent December 1, 2021 01:32
@dipeshmsft dipeshmsft self-assigned this Dec 1, 2021
Copy link
Contributor

@deeprobin deeprobin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dipeshmsft dipeshmsft merged commit d21ce7a into dotnet:main Jan 3, 2022
@ThomasGoulet73 ThomasGoulet73 deleted the managed-module-initializer branch January 3, 2022 14:18
@ghost ghost locked as resolved and limited conversation to collaborators Apr 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
PR metadata: Label to tag PRs, to facilitate with triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants