Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Setter.Value the ContentProperty for Setter #84

Open
thomaslevesque opened this issue Dec 5, 2018 · 5 comments · Fixed by #8534 · May be fixed by #9229
Open

Make Setter.Value the ContentProperty for Setter #84

thomaslevesque opened this issue Dec 5, 2018 · 5 comments · Fixed by #8534 · May be fixed by #9229
Assignees
@anjali-wpf
Labels
API suggestion Early API idea and discussion, it is NOT ready for implementation 🚧 work in progress Enhancement Requested Product code improvement that does NOT require public API changes/additions
Projects
Future Enhancements / Bugs

Comments

@thomaslevesque
Copy link
Member

Currently, when you want to set the value of a setter to a complex object (e.g. control template), you have to specify the <Setter.Value> element:

<Style TargetType="Button">
    <Setter Property="Template">
        <Setter.Value>
            <ControlTemplate TargetType="Button">
                ...
            </ControlTemplate>
        </Setter.Value>
    </Setter>
</Style>

But this element brings no value at all, it just adds noise. Making Value the ContentProperty for Setter would make the code a bit less verbose:

<Style TargetType="Button">
    <Setter Property="Template">
        <ControlTemplate TargetType="Button">
            ...
        </ControlTemplate>
    </Setter>
</Style>

(note: I tried to make this change, but I can't find the Setter class anywhere in the repo... nor can I find any of the controls. Where are they? Is there another repo?)
@rrelyea
Copy link

rrelyea commented Dec 5, 2018

Setter is in PresentationFramework.dll - that code is not yet in this repo. (System.Xaml to start).
Of course, if this change was wanted, you'd just add [ContentProperty("Value")] to the Setter class.

@thomaslevesque
Copy link
Member Author

Setter is in PresentationFramework.dll - that code is not yet in this repo.

I'll wait, then!

Of course, if this change was wanted, you'd just add [ContentProperty("Value")] to the Setter class.

Yes, that's what I thought. I've been ranting about this for years, so I'll be glad to be able to fix it 😉

@rladuca rladuca added the API suggestion Early API idea and discussion, it is NOT ready for implementation label Dec 5, 2018
@rladuca rladuca added this to the Future milestone Dec 5, 2018
@dotMorten
Copy link
Contributor

This is such an obvious and simple thing, I'm now wondering why I didn't think of that 😁 Awesome idea

@Felix-Dev Felix-Dev mentioned this issue Dec 10, 2018
Open
@thomasclaudiushuber thomasclaudiushuber mentioned this issue Apr 2, 2019
Open
@grubioe grubioe added this to Incoming / New in Future Enhancements / Bugs May 15, 2019
@thomasclaudiushuber thomasclaudiushuber mentioned this issue May 23, 2019
Merged
@vatsan-madhavan vatsan-madhavan added the Enhancement Requested Product code improvement that does NOT require public API changes/additions label May 24, 2019
@thomaslevesque thomaslevesque mentioned this issue May 31, 2019
Closed
@Symbai Symbai mentioned this issue Nov 4, 2019
Open
@thomaslevesque
Copy link
Member Author

Is there anything still blocking this feature? PR #745 has been open for months, can it be merged now that .NET Core 3.0 (and 3.1) has been released?

@bhood-zorus bhood-zorus mentioned this issue Mar 4, 2022
Open
@anjali-wpf anjali-wpf self-assigned this Dec 13, 2023
@anjali-wpf anjali-wpf mentioned this issue Dec 13, 2023
Merged
This was referenced Jan 29, 2024
Closed
Closed
Merged
@dotnet-policy-service dotnet-policy-service bot removed this from the Future milestone May 7, 2024
@hez2010
Copy link

hez2010 commented May 20, 2024

Should this issue be reopened given that the PR has been reverted?

@pchaurasia14 pchaurasia14 reopened this May 20, 2024
@anjali-wpf anjali-wpf linked a pull request Jun 7, 2024 that will close this issue
Draft
@anjali-wpf anjali-wpf mentioned this issue Jul 5, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anjali-wpf anjali-wpf

Labels
API suggestion Early API idea and discussion, it is NOT ready for implementation 🚧 work in progress Enhancement Requested Product code improvement that does NOT require public API changes/additions
Projects
No open projects
Future Enhancements / Bugs
Incoming / New
Milestone
No milestone
8 participants
@dotMorten @thomaslevesque @rrelyea @hez2010 @rladuca @vatsan-madhavan @anjali-wpf @pchaurasia14