Keep the Button HorizontalAlignment be Center in Fluent style #10082
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
requested review from
dipeshmsft,
singhashish-wpf and
Kuldeep-MS
dotnet-policy-service
bot
added
PR
|
@lindexi Run the theme generator ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10077
Description
In the Fluent style, ensure that the
HorizontalAlignmentproperty of buttons is set toCenter. This helps maintain consistent behavior with previous styles.Customer Impact
Maintaining consistent behavior allows developers to more easily apply the Fluent theme without worrying about layout changes due to style switches.
Regression
See #8870
Testing
Just CI and Snoop
Risk
Low. This potentially breaking scenarios where buttons relying on the Fluent style are left-aligned. Therefore, I believe the sooner this change is merged, the lower the risk will be, as fewer developers will depend on buttons being left-aligned.
Microsoft Reviewers: Open in CodeFlow