From 8c101b8b19fa3c58a781957dff59b203f790d7fb Mon Sep 17 00:00:00 2001 From: Nirmal Guru Date: Sun, 14 Jun 2020 09:26:08 +0530 Subject: [PATCH] Fixup new-lines making them easier to read Only in WinFX and Desktop SDK props/targets --- .../Microsoft.NET.Sdk.WindowsDesktop.props | 11 -- .../Microsoft.NET.Sdk.WindowsDesktop.targets | 4 - .../Microsoft.WinFX.targets | 119 ++---------------- 3 files changed, 11 insertions(+), 123 deletions(-) diff --git a/packaging/Microsoft.NET.Sdk.WindowsDesktop/targets/Microsoft.NET.Sdk.WindowsDesktop.props b/packaging/Microsoft.NET.Sdk.WindowsDesktop/targets/Microsoft.NET.Sdk.WindowsDesktop.props index 1da0f3c6cbc..7cc1c66bdbc 100644 --- a/packaging/Microsoft.NET.Sdk.WindowsDesktop/targets/Microsoft.NET.Sdk.WindowsDesktop.props +++ b/packaging/Microsoft.NET.Sdk.WindowsDesktop/targets/Microsoft.NET.Sdk.WindowsDesktop.props @@ -17,16 +17,13 @@ Irrespective of whether '$(TargetFrameworkIdentifier)' is '.NETCoreApp' or '.NETFramework', the minimum value of $(_TargetFrameworkVersionValue) we will be testing for is '3.0' - --> <_WindowsDesktopSdkTargetFrameworkVersionFloor>3.0 - <_UndefinedTargetFrameworkVersion>0.0 - @@ -50,8 +47,6 @@ Condition="'$(EnableDefaultPageItems)' != 'false'" > MSBuild:Compile - - - diff --git a/packaging/Microsoft.NET.Sdk.WindowsDesktop/targets/Microsoft.NET.Sdk.WindowsDesktop.targets b/packaging/Microsoft.NET.Sdk.WindowsDesktop/targets/Microsoft.NET.Sdk.WindowsDesktop.targets index 7eadb44fe25..5f6244a98b7 100644 --- a/packaging/Microsoft.NET.Sdk.WindowsDesktop/targets/Microsoft.NET.Sdk.WindowsDesktop.targets +++ b/packaging/Microsoft.NET.Sdk.WindowsDesktop/targets/Microsoft.NET.Sdk.WindowsDesktop.targets @@ -23,7 +23,6 @@ <_TargetFrameworkVersionValue>$([MSBuild]::ValueOrDefault('$(_TargetFrameworkVersionWithoutV)', '$(_UndefinedTargetFrameworkVersion)')) - @@ -33,7 +32,6 @@ --> - - - true - false 1.0.0.0 Installed true .g$(DefaultLanguageSourceExtension) - 5.1.2600.0 @@ -37,32 +33,24 @@ - true true true true - - - - AssignWinFXEmbeddedResource; $(PrepareResourceNamesDependsOn) - - - MarkupCompilePass1; AfterMarkupCompilePass1; @@ -71,38 +59,32 @@ MainResourcesGeneration; $(PrepareResourcesDependsOn) - - - DesignTimeMarkupCompilation; $(CoreCompileDependsOn) - - + - + - - @@ -128,52 +110,42 @@ - - - $(CompileDependsOn); _AfterCompileWinFXInternal - - - <_AfterCompileWinFXInternalDependsOn> PrepareResourcesForSatelliteAssemblies; MergeLocalizationDirectives; AfterCompileWinFX - - - + - - - @@ -320,7 +283,6 @@ If MarupCompilePass2 is for Main Assembly as well, output the Baml files into GeneratedBaml, FileClassifier task will be invoked later. --> - @@ -333,20 +295,15 @@ TaskParameter="GeneratedBaml" Condition="'$(_RequireMCPass2ForSatelliteAssemblyOnly)' == 'true'" /> - - - - - GenerateTemporaryTargetAssembly; MarkupCompilePass2; @@ -370,8 +325,6 @@ <_CompileTargetNameForLocalType Condition="'$(_CompileTargetNameForLocalType)' == ''">_CompileTemporaryAssembly - - @@ -380,18 +333,15 @@ - - - @@ -437,13 +383,10 @@ - - - - - true $(GenerateManifests) - - false - - Internet - - - $(TargetUrl)/$(TargetDeployManifestFileName) $(MSBuildProjectDirectory)\bin\$(Configuration)\$(TargetDeployManifestFileName) -debug "$(StartURL)" $(StartArguments) -DebugSecurityZoneURL "$(DebugSecurityZoneURL)" - @@ -551,8 +482,6 @@ - - @@ -577,7 +506,6 @@ CertificateThumbprint="$(_DeploymentResolvedManifestCertificateThumbprint)" TimestampUrl="$(ManifestTimestampUrl)" SigningTarget="@(ApplicationManifest)"/> - @@ -595,7 +523,6 @@ CertificateThumbprint="$(_DeploymentResolvedManifestCertificateThumbprint)" TimestampUrl="$(ManifestTimestampUrl)" SigningTarget="@(DeployManifest)"/> - @@ -605,7 +532,6 @@ ================================================================ Classify baml and image files into different groups for Main assembly and satellite assembly respectively. - --> @@ -623,12 +549,10 @@ - - - - - <_ResourceNameInMainAssembly Condition="'$(UICulture)' == ''">$(AssemblyName).g.resources - <_ResourceNameInMainAssembly Condition="'$(UICulture)' != ''">$(AssemblyName).unlocalizable.g.resources - - - - @@ -689,11 +605,10 @@ $(IntermediateOutputPath)$(_ResourceNameInMainAssembly) - - - - - + @@ -822,7 +732,6 @@ Condition="'$(UICulture)' != ''"> - @@ -833,7 +742,6 @@ Condition="'@(NonResxWithCulture)' != ''"> - @@ -844,7 +752,6 @@ - @@ -853,7 +760,6 @@ Condition="'@(Page)' != '' or '@(ApplicationDefinition)' != ''"> - - + - + - +