Convert BitBlt to cswin32 PInvoke #7446
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add HDC conversion to scopes - Remove unused BeginPath
JeremyKuhne
approved these changes
Jul 19, 2022
Closed
RussKie
reviewed
Jul 19, 2022
| GetCurrentProcessId | ||
| GlobalReAlloc | ||
| GlobalFree | ||
| BitBlt |
There was a problem hiding this comment.
Similar to #7444 (comment) - please have this file sorted in alphabetical order.
Comment on lines
13
to
21
| IHandle hdc, | ||
| int x, | ||
| int y, | ||
| int cx, | ||
| int cy, | ||
| HDC hdcSrc, | ||
| int x1, | ||
| int y1, | ||
| ROP_CODE rop) |
There was a problem hiding this comment.
Why did the indentation change?
There was a problem hiding this comment.
Oops! Must've happened by accident when I was moving things around.
Comment on lines
10
to
+14
| using System.Drawing.Imaging; | ||
| using System.Runtime.InteropServices; | ||
| using Windows.Win32; | ||
| using static Interop; | ||
| using Gdi = Windows.Win32.Graphics.Gdi; |
There was a problem hiding this comment.
[nit] Are these sorted? If not, please have these sorted (via the context menu):
Ditto below
RussKie
added
the
waiting-author-feedback
AArnott
approved these changes
Jul 19, 2022
ghost
removed
the
waiting-author-feedback
JeremyKuhne
pushed a commit
to JeremyKuhne/winforms
that referenced
this pull request
Jul 26, 2022
* Convert BitBlt to cswin32 PInvoke - Add HDC conversion to scopes - Remove unused BeginPath - NativeMethods.txt
RussKie
pushed a commit
that referenced
this pull request
Aug 9, 2022
* Convert BitBlt to cswin32 PInvoke - Add HDC conversion to scopes - Remove unused BeginPath - NativeMethods.txt
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Microsoft Reviewers: Open in CodeFlow