Prevent Toolbar tooltips from appearing directly under cursor hotspot #12959
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12959 +/- ##
===================================================
+ Coverage 62.15778% 62.24890% +0.09111%
===================================================
Files 1555 1557 +2
Lines 159256 159251 -5
Branches 14849 14864 +15
===================================================
+ Hits 98990 99132 +142
+ Misses 59522 59367 -155
- Partials 744 752 +8
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
| @@ -4505,6 +4505,7 @@ internal void UpdateToolTip(ToolStripItem? item, bool refresh = false) | |||
| if (_currentlyActiveTooltipItem is not null && !GetToolStripState(STATE_DRAGGING) && Cursor.Current is { } currentCursor) | |||
| { | |||
| Point cursorLocation = Cursor.Position; | |||
| cursorLocation.X += currentCursor.HotSpot.X + 1; | |||
There was a problem hiding this comment.
Might be worth putting a comment here explaining why the X coordinate is being fudged
|
@Olina-Zhang can your team build this fix and test it out? And can you (or @LeafShi1 ) update the PR branch so it's up to date? |
toehead2001
force-pushed
the
tooltip-offset
branch
from
1656019 to
977557a
Compare
|
@merriemcgaw @toehead2001 Tested this PR change, here is the result, please have a look:
WithPrivates_Case1Fixed.mp4
WithPrivates_Case2NotFixed.mp4 |
src/System.Windows.Forms/System/Windows/Forms/Controls/ToolStrips/ToolStrip.cs
Show resolved
Hide resolved
|
@Olina-Zhang - did issue2 become worse after the fix? |
No, same result as before. |
|
@merriemcgaw @Olina-Zhang - I think the second issue is minor and can be ignored, especially since it didn't get worse with this change. |
Tanya-Solyanik
added
the
ready-to-merge
dotnet-policy-service
bot
removed
the
ready-to-merge
Fixes #12958
Proposed changes
ToolTipso that it is offset by 1px from the cursor's HotSpot X value.Customer Impact
ToolStriptooltips from appearing directly under cursor HotSpot. Thus, the user is able to click theToolStripItem.Regression?
Risk
Screenshots
Before
After
Test methodology
Accessibility testing
Test environment(s)
Microsoft Reviewers: Open in CodeFlow