Address build failures

Author: RussKie

Directory.Build.props

@@ -16,6 +16,11 @@
     <LangVersion>preview</LangVersion>
   </PropertyGroup>
 
+  <!-- SDK flipped to 'true' by default https://github.com/dotnet/sdk/pull/12720 -->
+  <PropertyGroup>
+    <ProduceReferenceAssembly>false</ProduceReferenceAssembly>
+  </PropertyGroup>
+
   <!-- Allow SourceLink to work for strongly types resource files (SR) by embeddeding generated files into the PDBs -->
   <PropertyGroup>
     <EmbedUntrackedSources>true</EmbedUntrackedSources>

eng/Shipping.ruleset

@@ -237,6 +237,7 @@
     <Rule Id="CA1308" Action="None" />             <!-- Normalize strings to uppercase -->
     <Rule Id="CA1309" Action="None" />             <!-- Use ordinal stringcomparison -->
     <Rule Id="CA1401" Action="Warning" />          <!-- P/Invokes should not be visible -->
+    <Rule Id="CA1416" Action="None" />             <!-- Validate platform compatibility -->
     <Rule Id="CA1417" Action="Warning" />          <!-- Do not use 'OutAttribute' on string parameters for P/Invokes -->
     <Rule Id="CA1501" Action="None" />             <!-- Avoid excessive inheritance -->
     <Rule Id="CA1502" Action="None" />             <!-- Avoid excessive complexity -->

src/Microsoft.VisualBasic.Forms/src/Microsoft/VisualBasic/ApplicationServices/ApplicationBase.vb

@@ -18,7 +18,6 @@ Namespace Microsoft.VisualBasic.ApplicationServices
         Public Sub New()
         End Sub
 
-#Disable Warning CA1822 ' Mark members as static, Justification:=<Public API>
         ''' <summary>
         ''' Returns the value of the specified environment variable.
         ''' </summary>
@@ -27,7 +26,6 @@ Namespace Microsoft.VisualBasic.ApplicationServices
         ''' <exception cref="ArgumentNullException">if name is Nothing.</exception>
         ''' <exception cref="ArgumentException">if the specified environment variable does not exist.</exception>
         Public Function GetEnvironmentVariable(name As String) As String
-#Enable Warning CA1822 ' Mark members as static
 
             ' Framework returns Null if not found.
             Dim VariableValue As String = Environment.GetEnvironmentVariable(name)
@@ -94,7 +92,6 @@ Namespace Microsoft.VisualBasic.ApplicationServices
             End Get
         End Property
 
-#Disable Warning CA1822 ' Mark members as static, Justification:=<Public API>
         ''' <summary>
         ''' Changes the culture currently in used by the current thread.
         ''' </summary>
@@ -117,7 +114,6 @@ Namespace Microsoft.VisualBasic.ApplicationServices
         Public Sub ChangeUICulture(cultureName As String)
             Threading.Thread.CurrentThread.CurrentUICulture = New Globalization.CultureInfo(cultureName)
         End Sub
-#Enable Warning CA1822 ' Mark members as static
 
         Private _log As Logging.Log 'Lazy-initialized and cached log object.
         Private _info As AssemblyInfo ' The executing application (the EntryAssembly)

src/Microsoft.VisualBasic.Forms/src/Microsoft/VisualBasic/ApplicationServices/WindowsFormsApplicationBase.vb

@@ -1,4 +1,4 @@
-' Licensed to the .NET Foundation under one or more agreements.
+' Licensed to the .NET Foundation under one or more agreements.
 ' The .NET Foundation licenses this file to you under the MIT license.
 ' See the LICENSE file in the project root for more information.
 
@@ -442,12 +442,10 @@ Namespace Microsoft.VisualBasic.ApplicationServices
             End Set
         End Property
 
-#Disable Warning CA1822 ' Mark members as static, Justification:=<Public API>
         ''' <summary>
         '''  Processes all windows messages currently in the message queue
         ''' </summary>
         Public Sub DoEvents()
-#Enable Warning CA1822 ' Mark members as static
             Windows.Forms.Application.DoEvents()
         End Sub
 

src/Microsoft.VisualBasic.Forms/src/Microsoft/VisualBasic/Devices/Audio.vb

@@ -1,4 +1,4 @@
-' Licensed to the .NET Foundation under one or more agreements.
+' Licensed to the .NET Foundation under one or more agreements.
 ' The .NET Foundation licenses this file to you under the MIT license.
 ' See the LICENSE file in the project root for more information.
 
@@ -85,7 +85,6 @@ Namespace Microsoft.VisualBasic
                 Play(New Media.SoundPlayer(stream), playMode)
             End Sub
 
-#Disable Warning CA1822 ' Mark members as static, Justification:=<Public API>
             ''' <summary>
             '''   Plays a system messageBeep sound.
             ''' </summary>
@@ -107,7 +106,6 @@ Namespace Microsoft.VisualBasic
                 Dim sound As New Media.SoundPlayer()
                 sound.Stop()
             End Sub
-#Enable Warning CA1822 ' Mark members as static
 
             ''' <summary>
             '''  Plays the passed in SoundPlayer in the passed in mode

src/Microsoft.VisualBasic.Forms/src/Microsoft/VisualBasic/Devices/Keyboard.vb

@@ -24,15 +24,13 @@ Namespace Microsoft.VisualBasic.Devices
             SendKeys(keys, False)
         End Sub
 
-#Disable Warning CA1822 ' Mark members as static, Justification:=<Public API>
         ''' <summary>
         ''' Sends keys to the active window as if typed at keyboard. This overloaded
         ''' version uses the same conventions as the VB6 SendKeys.
         ''' </summary>
         ''' <param name="keys">A string containing the keys to be sent (typed).</param>
         ''' <param name="wait">Wait for messages to be processed before returning.</param>
         Public Sub SendKeys(keys As String, wait As Boolean)
-#Enable Warning CA1822 ' Mark members as static
             If wait Then
                 Windows.Forms.SendKeys.SendWait(keys)
             Else

src/Microsoft.VisualBasic.Forms/src/Microsoft/VisualBasic/Devices/Network.vb

@@ -1,4 +1,4 @@
-' Licensed to the .NET Foundation under one or more agreements.
+' Licensed to the .NET Foundation under one or more agreements.
 ' The .NET Foundation licenses this file to you under the MIT license.
 ' See the LICENSE file in the project root for more information.
 
@@ -334,7 +334,6 @@ Namespace Microsoft.VisualBasic.Devices
 
         End Sub
 
-#Disable Warning CA1822 ' Mark members as static, Justification:=<Public API>
         ''' <summary>
         ''' Downloads a file from the network to the specified path
         ''' </summary>
@@ -353,8 +352,6 @@ Namespace Microsoft.VisualBasic.Devices
                     connectionTimeout As Integer,
                     overwrite As Boolean,
                     onUserCancel As UICancelOption)
-#Enable Warning CA1822 ' Mark members as static
-
             If connectionTimeout <= 0 Then
                 Throw GetArgumentExceptionWithArgName("connectionTimeOut", SR.Network_BadConnectionTimeout)
             End If
@@ -581,7 +578,6 @@ Namespace Microsoft.VisualBasic.Devices
             UploadFile(sourceFileName, address, networkCredentials, showUI, connectionTimeout, UICancelOption.ThrowException)
         End Sub
 
-#Disable Warning CA1822 ' Mark members as static, Justification:=<Public API>
         ''' <summary>
         ''' Uploads a file from the local machine to the specified host
         ''' </summary>
@@ -597,8 +593,6 @@ Namespace Microsoft.VisualBasic.Devices
                               showUI As Boolean,
                               connectionTimeout As Integer,
                               onUserCancel As UICancelOption)
-#Enable Warning CA1822 ' Mark members as static
-
             sourceFileName = FileSystemUtils.NormalizeFilePath(sourceFileName, "sourceFileName")
 
             'Make sure the file exists

src/Microsoft.VisualBasic.Forms/src/Microsoft/VisualBasic/Helpers/NativeMethods.vb

@@ -27,10 +27,10 @@ Namespace Microsoft.VisualBasic.CompilerServices
             GetDesktopWindow _
                 Lib "user32" () As IntPtr
 
-#Disable Warning CA2101 ' Specify marshaling for P/Invoke string arguments
+#Disable Warning CA1838 ' Avoid 'StringBuilder' parameters for P/Invokes
         <DllImport("user32", CharSet:=CharSet.Auto, PreserveSig:=True, SetLastError:=True)>
         Friend Shared Function GetWindowText(hWnd As IntPtr, <Out(), MarshalAs(UnmanagedType.LPTStr)> lpString As StringBuilder, nMaxCount As Integer) As Integer
-#Enable Warning CA2101 ' Specify marshaling for P/Invoke string arguments
+#Enable Warning CA1838 ' Avoid 'StringBuilder' parameters for P/Invokes
         End Function
 
         <PreserveSig()>
@@ -48,12 +48,10 @@ Namespace Microsoft.VisualBasic.CompilerServices
             SetFocus _
                 Lib "user32" (hwnd As IntPtr) As IntPtr
 
-#Disable Warning CA2101 ' Specify marshaling for P/Invoke string arguments
         <PreserveSig()>
         Friend Declare Auto Function _
             FindWindow _
                 Lib "user32" (lpClassName As String, lpWindowName As String) As IntPtr
-#Enable Warning CA2101 ' Specify marshaling for P/Invoke string arguments
 
         <PreserveSig()>
         Friend Declare Function _

src/Microsoft.VisualBasic.Forms/src/Microsoft/VisualBasic/Interaction.vb

@@ -1,13 +1,12 @@
-' Licensed to the .NET Foundation under one or more agreements.
+' Licensed to the .NET Foundation under one or more agreements.
 ' The .NET Foundation licenses this file to you under the MIT license.
 ' See the LICENSE file in the project root for more information.
 
-Imports System.Text
-Imports System.Threading
 Imports System.Runtime.CompilerServices
 Imports System.Runtime.InteropServices
 Imports System.Security
-
+Imports System.Text
+Imports System.Threading
 Imports Microsoft.VisualBasic.CompilerServices
 Imports Microsoft.VisualBasic.CompilerServices.ExceptionUtils
 Imports Microsoft.VisualBasic.CompilerServices.Utils
@@ -261,10 +260,8 @@ Namespace Microsoft.VisualBasic
             Public Sub StartHere()
                 Try
                     _result = InternalInputBox(_prompt, _title, _defaultResponse, _xPos, _yPos, _parentWindow)
-#Disable Warning CA1031 ' Do not catch general exception types
                 Catch ex As Exception
                     _exception = ex
-#Enable Warning CA1031 ' Do not catch general exception types
                 End Try
             End Sub
 

src/Microsoft.VisualBasic.Forms/src/Microsoft/VisualBasic/MyServices/ClipboardProxy.vb

@@ -1,4 +1,4 @@
-' Licensed to the .NET Foundation under one or more agreements.
+' Licensed to the .NET Foundation under one or more agreements.
 ' The .NET Foundation licenses this file to you under the MIT license.
 ' See the LICENSE file in the project root for more information.
 
@@ -26,7 +26,6 @@ Namespace Microsoft.VisualBasic.MyServices
         Friend Sub New()
         End Sub
 
-#Disable Warning CA1822 ' Mark members as static, Justification:=<Public API>
         ''' <summary>
         ''' Gets text from the clipboard
         ''' </summary>
@@ -212,6 +211,5 @@ Namespace Microsoft.VisualBasic.MyServices
         Public Sub SetDataObject(data As System.Windows.Forms.DataObject)
             Clipboard.SetDataObject(data)
         End Sub
-#Enable Warning CA1822 ' Mark members as static
     End Class
 End Namespace