Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Razor to include more C# actions #3524

Merged

Conversation

ryanbrandenburg
Copy link
Contributor

Copy link
Contributor

@ajaybhargavb ajaybhargavb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

CHANGELOG.md Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@NTaylorMullen
Copy link
Contributor

@ryanbrandenburg the build failure looks legit. Since we removed a good amount of telemetry this test is now failing: https://github.com/OmniSharp/omnisharp-vscode/blob/2edb8414981d49185ce9fe783187008ab343678b/test/razorTests/razorTelemetry.integration.test.ts#L46

Sadly there isn't a Razor telemetry event that O# can capture during their tests because the suite teardown/restore is when all of our existing telemetry events fire and during test time you can't control exactly when that happens.

@codecov
Copy link

codecov bot commented Jan 24, 2020

Codecov Report

Merging #3524 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #3524   +/-   ##
======================================
  Coverage    89.8%   89.8%           
======================================
  Files          59      59           
  Lines        1589    1589           
  Branches       89      89           
======================================
  Hits         1427    1427           
  Misses        151     151           
  Partials       11      11
Flag Coverage Δ
#integration 100% <ø> (ø) ⬆️
#unit 89.8% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b4295e...1dea550. Read the comment docs.

@ryanbrandenburg ryanbrandenburg force-pushed the rybrande/RazorInsertionLSPPreview1 branch from 09030fa to 1305d32 Compare January 24, 2020 18:44
@ryanbrandenburg
Copy link
Contributor Author

@JoeRobich FYI the telemetry test is being removed because we no longer publish that telemetry event. That seemed to be the only test in it's suite so I removed the suite and its infrastructure too.

Copy link
Member

@JoeRobich JoeRobich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be great!

@JoeRobich JoeRobich merged commit d1a9e2d into dotnet:master Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants