-
Notifications
You must be signed in to change notification settings - Fork 667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Go to definition for a source generated file fails to open the generated file #6426
Comments
This affects us in a project that uses RefitGenerator.
|
I get this bug on a Godot project too. Godot uses source generators. |
I'm adding source generators to OpenRA/OpenRA#21234 and this is proving to be a blocker for us! |
@penev92 you can workaround this by setting |
Even then the C# extension throws on all navigation operations that deal with creating an URL for generated code and once I manually open a generated file it can't use any symbols in it to navigate out. |
I'm getting the same error and not sure why.
|
FYI: this is also blocking any 'Find all references' functionality for me. |
This temporary fix introduced here |
Having it set to OmniSharp used to solve the issue IIRC, but now, when using "jump to definition" or "find all references" of Godot partial classes in OmniSharp, I do get to see the generated code in the popup thingy, but when clicking to actually open it in a new tab, there's another issue, an error in the Virtual Text Document Provider, it seems:
In the dev tools console log:
|
@geekley Who was "they" in this case? |
The latest update of v2.15.30 seems to have fixed the issue. Was able to find references without errors for a Godot (v4.2.1) project. Would like a second opinion from anyone else who was previously facing this issue. |
Used to get the
Using the latest insider build:
and vscode-csharp Edit: Context: |
Extension version 2.15.30 appears to have resolved the go to symbol, go to definition, and go to implementations issues for me, too. This is a huge improvement in the experience for me and my team--thanks very much to the maintainers. |
To clarify a bit: there's still more work to do to make Go to Definition to source generated files actually work. To give a bit of a sense how this works:
The UriFormatException was because we had a place that wasn't correctly doing the first step. So if you had find references that found 10 references, and just one happened to be in a source generated file, then we'd fail to create the URI properly and thus the entire request would fail. Which was icky. So we fixed that; the work for step 2 isn't in, which is why @JeremyTCD is getting the error he's seeing. But that'll only happen if you actually need to open a generated file. In my example of Find References w/ 10 references, at least now you can view the other 9. 😄 I'm leaving this bug open until I actually fix the end-to-end though. I'll retitle it. |
@jasonmalinowski thanks for clarifying, appreciate the work you're putting into this issue! |
@jasonmalinowski any update on this? |
@hutterm It's in code review now, so should land if not this week then next week. |
@jasonmalinowski two weeks have passed, any update here? |
@arsinclair This demonstrates why I should never give a promise of a ship date -- I'm now on leave with the arrival of our new baby. 👶 We'll have somebody else wrap up the work but we're still handing that off. |
three months now :/ |
As I remember it should work now. I updated my extension and it works good. |
Does navigating to source generator generated files work for you? Still broken for me with the latest updates. |
Still broken... |
this is embarrassing and makes me switch to Jetbrains ide sometimes |
Still occurring. Even using the |
Any plans for this to get fixed? This is a blocker which forces me to use other IDEs... |
Bump! |
Repro:
Syntax.xml.Syntax.Generated.cs
- for exampleBaseTypeDeclarationSyntax
hereThe text was updated successfully, but these errors were encountered: