Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mechanism to suppress 'Get .NET CLI tools' error message #603

Closed
gregg-miskelly opened this issue Jul 22, 2016 · 2 comments
Closed

Add mechanism to suppress 'Get .NET CLI tools' error message #603

gregg-miskelly opened this issue Jul 22, 2016 · 2 comments

Comments

@gregg-miskelly
Copy link
Contributor

gregg-miskelly commented Jul 22, 2016

Steps to reproduce

Install the C# extension for the purposes of Unity development
Open a Unity Project

Expected behavior

No reference to the .NET CLI since you aren't working on a scenario involving .NET Core

Possible fixes

The code for this is in active.ts:

if (!isDotnetOnPath()) {
    const getDotNetMessage = "Get .NET CLI tools"; 
    vscode.window.showErrorMessage("The .NET CLI tools cannot be located. .NET Core debugging will not be enabled. Make sure .NET CLI tools are installed and are on the path.",
        getDotNetMessage).then(value => {

Two possible fixes:

  1. Instead of downloading the debugger on C# extension activation, we download it when opening a .NET Core App or when they first try to start debugging.
  2. Instead of using an error message, maybe we can use a different piece of VS Code UI that lets the user pick 'never show me this again'.
@caslan caslan added this to the 1.4 milestone Aug 10, 2016
@wesrupert wesrupert self-assigned this Aug 23, 2016
wesrupert added a commit that referenced this issue Aug 23, 2016
- Add a user option to suppress the "Get .NET CLI tools" popup that appears when the tools are not found.
- Add a navigation point to the settings page to the popup.

Fix for #603.
@wesrupert
Copy link
Contributor

PR #700 provides a mechanism to get the message to stop appearing. However, leaving this open to track implementing fix 1.

@wesrupert wesrupert removed their assignment Aug 23, 2016
@wesrupert wesrupert removed this from the 1.4 milestone Aug 23, 2016
@gregg-miskelly
Copy link
Contributor Author

With this new download system, I don't think it makes sense to do fix 1 anymore. So closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants