Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variable scope not being seen properly in Dark/Light (Visual Studio) themes #34

Closed
aeschli opened this issue Feb 11, 2016 · 4 comments
Closed

Comments

@aeschli
Copy link
Contributor

aeschli commented Feb 11, 2016

From @rhires on February 11, 2016 3:2

image

I wanted to title this "It's not just a mouthwash!" but...
Anyway, this brought me back to making sure I knew about scope - when I have a variable outside of the if statement, and then reference it inside the if statement, the system shouldn't complain about that. It's perfectly valid syntax. Why does VSCode think my variable is unused?

This is a C# file (which the little info in the bottom info bar agrees with), running 0.10.8, on Mac OS X Yosemite. This appears to be a new issue.

Copied from original issue: microsoft/vscode#2916

@aeschli
Copy link
Contributor Author

aeschli commented Feb 11, 2016

From @Tyriar on February 11, 2016 3:10

The variable is assigned but not used, a warning is expected because technically the variable is still doing nothing.

var should be colored though, I can reproduce it. It looks like it's a problem with the "Dark (Visual Studio)" and "Light (Visual Studio)" themes.

@aeschli
Copy link
Contributor Author

aeschli commented Feb 11, 2016

Moving to OmniSharp for commenting on the warning on the variable.
@Tyriar Let's have a separate issue for the 'var' coloring.

@DustinCampbell
Copy link
Member

Thanks. Will take a look!

@DustinCampbell
Copy link
Member

The issue with the warning is by design. We were tracking the colorization issue with #100, but haven't been to reproduce it in a long while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants