Newline formatting options #313

CuddleBunny · 2016-05-12T15:31:58Z

Looking for a way to configure auto-format for newlines. I'm a fan of this structure:

void foo() {
    if (something) {
        bar();
    } else {
        baz();
    }
}

However the current auto-format will place all my curly braces on a new line. I've noticed that both TypeScript and JavaScript have the options placeOpenBraceOnNewLineForControlBlocks and placeOpenBraceOnNewLineForFunctions.

The text was updated successfully, but these errors were encountered:

MGillson · 2016-06-16T19:32:23Z

I agree. I have found the forced formatting annoying. Is there any plans for configuring how the formatting works?

unalone · 2016-08-08T10:46:01Z

Agree+1

We need rights to format code as what we need, not the fixed role!

koppert · 2016-09-21T13:34:32Z

+1

Thaina · 2016-12-23T05:59:14Z

In the meantimes we could create omnisharp.json which contains many property about omnisharp, and then restart omnisharp

This is what I use

{
	"FormattingOptions": {
		"NewLinesForBracesInLambdaExpressionBody": false,
		"NewLinesForBracesInAnonymousMethods": false,
		"NewLinesForBracesInAnonymousTypes": false,
		"NewLinesForBracesInControlBlocks": true, // You need to change this
		"SpaceAfterControlFlowStatementKeyword": false,
		"SpaceAfterComma": false
	}
}

However I would also support that omnisharp should also add vscode config contribution point

bbugh · 2017-01-07T13:53:13Z

If you're like me (and I know I am) you want the brackets on the same line for everything, not just control blocks. Here's the full listing for all of the common squirrely bracket cases.

Put this in the base of your project as omnisharp.json
open the command palette and run Omnisharp: Restart Omnisharp.

{
	"FormattingOptions": {
		"NewLinesForBracesInLambdaExpressionBody": false,
		"NewLinesForBracesInAnonymousMethods": false,
		"NewLinesForBracesInAnonymousTypes": false,
		"NewLinesForBracesInControlBlocks": false,
		"NewLinesForBracesInTypes": false,
		"NewLinesForBracesInMethods": false,
                "NewLinesForBracesInProperties": false,
                "NewLinesForBracesInAccessors": false,
		"NewLineForElse": false,
		"NewLineForCatch": false,
		"NewLineForFinally": false
	}
}

Omnisharp doesn't presently reload the omnisharp.json files automatically, so if you make changes while you're in the editor, you'll have to restart Omnisharp again.

It's possible that I missed a couple of NewLine settings for edge cases. The formatting options don't seem to be documented anywhere, but you can see them all in the code: http://source.roslyn.codeplex.com/#Microsoft.CodeAnalysis.CSharp.Workspaces/Formatting/CSharpFormattingOptions.cs,dac739b7b8a53984

HURRAY! This was the only thing left that was still bugging me about vscode. Thanks @Thaina for the PROTIP.

filipw · 2017-01-07T14:25:04Z

Omnisharp doesn't presently reload the omnisharp.json files automatically, so if you make changes while you're in the editor, you'll have to restart Omnisharp again.

that's correct, this is planned to change though, the config file will be watched. it's tracked here OmniSharp/omnisharp-roslyn#366 (comment)

The formatting options don't seem to be documented anywhere, but you can see them all in the code:

I wrote a wiki page about dealing with omnisharp config here https://github.com/OmniSharp/omnisharp-roslyn/wiki/Configuration%20Options but indeed, the individual options are just picked up from Roslyn directly.

unalone · 2017-01-09T08:59:14Z

I’ve tried this, but nothing happened, when I try to format code, it still places every braces in new line, shit….

…

On 7 Jan 2017, at 21:53, Brian Bugh ***@***.***> wrote: If you're like me (and I know I am) you want the brackets on the same line for everything, not just control blocks. Here's the full listing for all of the common squirrely bracket cases. Put this in the base of your project as omnisharp.json open the command palette and run Omnisharp: Restart Omnisharp. { "FormattingOptions": { "NewLinesForBracesInLambdaExpressionBody": false, "NewLinesForBracesInAnonymousMethods": false, "NewLinesForBracesInAnonymousTypes": false, "NewLinesForBracesInControlBlocks": false, "NewLinesForBracesInTypes": false, "NewLinesForBracesInMethods": false, "NewLineForElse": false, "NewLineForCatch": false, "NewLineForFinally": false } } Omnisharp doesn't presently reload the omnisharp.json files automatically, so if you make changes while you're in the editor, you'll have to restart Omnisharp again. It's possible that I missed a couple of NewLine settings for edge cases. The formatting options don't seem to be documented anywhere, but you can see them all in the code: http://source.roslyn.codeplex.com/#Microsoft.CodeAnalysis.CSharp.Workspaces/Formatting/CSharpFormattingOptions.cs,dac739b7b8a53984 <http://source.roslyn.codeplex.com/#Microsoft.CodeAnalysis.CSharp.Workspaces/Formatting/CSharpFormattingOptions.cs,dac739b7b8a53984> HURRAY! This was the only thing left that was still bugging me about vscode. Thanks @Thaina <https://github.com/Thaina> for the PROTIP. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#313 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAJExmr02gXgvz4BgsAdFt6Wn_CvNnnhks5rP5jVgaJpZM4IdMcI>.

Thaina · 2017-01-09T09:04:00Z

@unalone Have you restart omnisharp?

unalone · 2017-01-09T09:06:55Z

Sure, I have created a new file named “omnisharp.json”, and placed this file under my root path of project, also, I added a line in my settings.json file like this: "omnisharp.json": “/path/to/omnisharp.json” And then I restart the vs code and nothing happened….. what’s wrong?

…

On 9 Jan 2017, at 17:04, Thaina Yu ***@***.***> wrote: @unalone <https://github.com/unalone> Have you restart omnisharp? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#313 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAJExu4qm17-Cx2W8Oq5TNd9yAG1ppWtks5rQfgFgaJpZM4IdMcI>.

Thaina · 2017-01-09T09:09:15Z

@unalone First, I think you should not put that line in settings.json
Second, you may need to restart omnisharp too in addition to restart vscode
Third, if above don't work I wish you would try with a new fresh blank project

unalone · 2017-01-09T09:11:01Z

First, this file is under the root path of my project. Second, I both tried to restart the OmniSharp and VS Code, nothin happened...

…

On 9 Jan 2017, at 17:09, Thaina Yu ***@***.***> wrote: First, I think you should not put that line in settings.json Second, you may need to restart omnisharp too in addition to restart vscode — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#313 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAJExpaKw1TvJrMWrODQaeswiLBSN3R5ks5rQflBgaJpZM4IdMcI>.

unalone · 2017-01-09T10:51:55Z

Ok, the reason is my C# plugin was out of date, everything goes well after update them, thank you :)

…

On 9 Jan 2017, at 17:09, Thaina Yu ***@***.***> wrote: First, I think you should not put that line in settings.json Second, you may need to restart omnisharp too in addition to restart vscode — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#313 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAJExpaKw1TvJrMWrODQaeswiLBSN3R5ks5rQflBgaJpZM4IdMcI>.

filipw · 2017-01-09T14:01:50Z

one more thing, regarding documentation - you can also use omnisharp.json from schemastore.org here http://json.schemastore.org/omnisharp

@DustinCampbell I think this issue can be closed as it seems everything needed here has been explained/addressed.

Omnisharp.json auto-reload is tracked in the omnisharp repo OmniSharp/omnisharp-roslyn#366 (comment)

unalone · 2017-01-09T16:26:35Z

so, why won't the omnisharp.json file be configured globally?

…

Sent from my iPhone

On 9 Jan 2017, at 22:01, Filip W ***@***.***> wrote: one more thing, regarding documentation - you can also use omnisharp.json from schemastore.org here http://json.schemastore.org/omnisharp @DustinCampbell I think this issue can be closed as it seems everything needed here has been explained/addressed. Omnisharp.json auto-reload is tracked in the omnisharp repo OmniSharp/omnisharp-roslyn#366 (comment) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

filipw · 2017-01-09T17:50:56Z

it will - this is tracked in separate issue already OmniSharp/omnisharp-roslyn#717

DustinCampbell · 2017-01-09T21:44:58Z

Sounds good @filipw. Closing this issue.

Thaina · 2017-01-27T12:34:54Z

@filipw Have you include schemastore/omnisharp into jsonvalidator contribution point of vscode extension yet?

DustinCampbell · 2017-01-27T13:20:24Z

Nope. That's my fault. I've commented on the PR.

DustinCampbell closed this as completed Jan 9, 2017

bbugh mentioned this issue Jan 13, 2017

Formatting C# removes all indentation TheColorRed/vscode-format#5

Open

fahall mentioned this issue Jul 30, 2018

Config File Location After emacs Install? OmniSharp/omnisharp-emacs#441

Open

simonsanchezart mentioned this issue Jan 5, 2023

Formatter ignoring 'NewLinesForX' in omnisharp.json #5517

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Newline formatting options #313

Newline formatting options #313

CuddleBunny commented May 12, 2016

MGillson commented Jun 16, 2016

unalone commented Aug 8, 2016

koppert commented Sep 21, 2016

Thaina commented Dec 23, 2016 •

edited

Loading

bbugh commented Jan 7, 2017 •

edited

Loading

filipw commented Jan 7, 2017

unalone commented Jan 9, 2017 via email

Thaina commented Jan 9, 2017

unalone commented Jan 9, 2017 via email

Thaina commented Jan 9, 2017 •

edited

Loading

unalone commented Jan 9, 2017 via email

unalone commented Jan 9, 2017 via email

filipw commented Jan 9, 2017

unalone commented Jan 9, 2017 via email

filipw commented Jan 9, 2017

DustinCampbell commented Jan 9, 2017

Thaina commented Jan 27, 2017

DustinCampbell commented Jan 27, 2017

Newline formatting options #313

Newline formatting options #313

Comments

CuddleBunny commented May 12, 2016

MGillson commented Jun 16, 2016

unalone commented Aug 8, 2016

koppert commented Sep 21, 2016

Thaina commented Dec 23, 2016 • edited Loading

bbugh commented Jan 7, 2017 • edited Loading

filipw commented Jan 7, 2017

unalone commented Jan 9, 2017 via email

Thaina commented Jan 9, 2017

unalone commented Jan 9, 2017 via email

Thaina commented Jan 9, 2017 • edited Loading

unalone commented Jan 9, 2017 via email

unalone commented Jan 9, 2017 via email

filipw commented Jan 9, 2017

unalone commented Jan 9, 2017 via email

filipw commented Jan 9, 2017

DustinCampbell commented Jan 9, 2017

Thaina commented Jan 27, 2017

DustinCampbell commented Jan 27, 2017

Thaina commented Dec 23, 2016 •

edited

Loading

bbugh commented Jan 7, 2017 •

edited

Loading

Thaina commented Jan 9, 2017 •

edited

Loading