Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SignatureHelp UI is still open when completionlist ui open #18

Closed
jrieken opened this issue Jan 26, 2016 · 4 comments
Closed

SignatureHelp UI is still open when completionlist ui open #18

jrieken opened this issue Jan 26, 2016 · 4 comments

Comments

@jrieken
Copy link
Contributor

jrieken commented Jan 26, 2016

From @BleyChen on January 26, 2016 9:47

Repro steps:

  1. type c# code as following to trigger the SignatureHelp UI:
    Console.Beep(
  2. backspace four characters ,signaturehelp ui still exists when completionlist ui display

33

Copied from original issue: microsoft/vscode#2274

@DustinCampbell
Copy link
Member

@jrieken -- how would this be an extension issue?

@jrieken
Copy link
Contributor Author

jrieken commented Jan 27, 2016

Signature help works like this in VS Code.

  1. you register a trigger character, like (
  2. when that is hit the language service is asked for signature help on basically each subsequent character being typed
  3. signature help stops/hides when the language service returns something falsy (undefined et al)

@DustinCampbell
Copy link
Member

got it -- thanks!

@DustinCampbell
Copy link
Member

This was fixed by #107

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants