Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the Microsoft.IO.Redist package version for CPM to version 6.0.1 #8248

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

marcpopMSFT
Copy link
Member

No description provided.

@marcpopMSFT marcpopMSFT requested a review from a team as a code owner July 29, 2024 21:20
@ericstj
Copy link
Member

ericstj commented Aug 8, 2024

Looks to me like this will impact

<PackageReference Include="Microsoft.Build.Framework" Publish="false" ExcludeAssets="runtime" />
. Can we check the output of that? What does it ship?

@ericstj
Copy link
Member

ericstj commented Aug 8, 2024

I built this branch locally and examined Microsoft.TemplateEngine.Authoring.Tasks to ensure no new package references were added it its nuspec, IO.Redist.dll does not appear in the content (the "excludeassets" is preserved from the MSBuild reference).

I do see that the new version of IO.Redist is added to
Microsoft.TemplateEngine.Authoring.Tasks.9.0.100-dev.nupkg.730\tools\netframework\Microsoft.TemplateEngine.Authoring.Tasks.dll.config

      <dependentAssembly>
        <assemblyIdentity name="Microsoft.IO.Redist" publicKeyToken="cc7b13ffcd2ddd51" culture="neutral" />
        <bindingRedirect oldVersion="0.0.0.0-6.0.0.1" newVersion="6.0.0.1" />
      </dependentAssembly>

I don't think MSBuild even honors these - maybe we should stop shipping them. @rainersigwald

@marcpopMSFT
Copy link
Member Author

@ericstj @rainersigwald what are the next steps I should take here? Should I exclude the reference in source build like I did in installer?

@ericstj
Copy link
Member

ericstj commented Aug 12, 2024

I think it would be nice to know if you could actually remove that config file, since it mentions things which aren't included in the package at all and may be a higher version than what's provided by MSBuild.

This is yet another Task that's responsible for updating MSBuild's dependencies. We need an SDK to avoid these cc @baronfel.

Copy link
Member

@ericstj ericstj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't make things worse than what was here before, but you should follow up on eliminating the config file.

@marcpopMSFT
Copy link
Member Author

@rainersigwald is there a flag to not generate that config file I can include in this PR?

@marcpopMSFT marcpopMSFT merged commit 17559df into main Aug 13, 2024
10 checks passed
@ViktorHofer ViktorHofer deleted the marcpopMSTF-ioreference branch August 27, 2024 08:58
@ViktorHofer
Copy link
Member

ViktorHofer commented Aug 27, 2024

@marcpopMSFT yes, you can set the following two properties to disable the creation of an app.config file for .NET Framework:

    <AutoGenerateBindingRedirects>false</AutoGenerateBindingRedirects>
    <GenerateSupportedRuntime>false</GenerateSupportedRuntime>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants