Use Try... pattern to register services to minimize duplication #516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If someone calls `.AddSystemWebAdapters()` multiple times in order to add more services to it, it registers the initial services multiple times as well. This is ok, except that the startup filter we use to register middleware will now exist multiple times and will register duplicated features on each invocation
twsouthwick
changed the title
joperezr
reviewed
Aug 7, 2024
Member
joperezr
left a comment
joperezr
left a comment
There was a problem hiding this comment.
Changes look good, but should we also add a test here that calls this methods multiple times and then ensures that the serviceCollection has the right number of services registered?
Member
Author
|
Added a test |
joperezr
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If someone calls
.AddSystemWebAdapters()multiple times in order to add more services to it, it registers the initial services multiple times as well. This is ok, except that the startup filter we use to register middleware will now exist multiple times and will register duplicated features on each invocation