Run ./update-apis.ps1 as part of build (#181)

This change fixes up the ./update-apis.ps1 script to only make changes
if something has changed. As part of this, the build server can now run
the script to ensure all the APIs are in the type forwards or reference
assembly.

Author: twsouthwick

azure-pipelines.yml

@@ -91,6 +91,13 @@ stages:
           name: Build
           displayName: Build
           condition: succeeded()
+        - task: PowerShell@2
+          inputs:
+            filePath: update_apis.ps1
+            argument: -c $(_BuildConfig)
+          name: VerifyTypeForwardsRef
+          displayName: Verify TypeForwards/Reference assembly
+          condition: succeeded()
         - task: PublishTestResults@2
           displayName: Publish xUnit Test Results
           condition: always()
@@ -136,6 +143,13 @@ stages:
           name: Build
           displayName: Build
           condition: succeeded()
+        - task: PowerShell@2
+          inputs:
+            filePath: update_apis.ps1
+            argument: -c $(_BuildConfig)
+          name: VerifyTypeForwardsRef
+          displayName: Verify TypeForwards/Reference assembly
+          condition: succeeded()
         - task: PublishTestResults@2
           displayName: Publish xUnit Test Results
           condition: always()
@@ -173,6 +187,13 @@ stages:
           name: Build
           displayName: Build
           condition: succeeded()
+        - task: PowerShell@2
+          inputs:
+            filePath: update_apis.ps1
+            argument: -c $(_BuildConfig)
+          name: VerifyTypeForwardsRef
+          displayName: Verify TypeForwards/Reference assembly
+          condition: succeeded()
         - task: PublishTestResults@2
           displayName: Publish xUnit Test Results
           condition: always()

src/Microsoft.AspNetCore.SystemWebAdapters/ExcludedApis.txt renamed to src/Microsoft.AspNetCore.SystemWebAdapters/Generated/ExcludedApis.txt

@@ -7,7 +7,12 @@ M:System.Web.HttpRequest.op_Implicit(Microsoft.AspNetCore.Http.HttpRequest)~Syst
 M:System.Web.HttpRequest.op_Implicit(System.Web.HttpRequest)~Microsoft.AspNetCore.Http.HttpRequest
 M:System.Web.HttpResponse.op_Implicit(Microsoft.AspNetCore.Http.HttpResponse)~System.Web.HttpResponse
 M:System.Web.HttpResponse.op_Implicit(System.Web.HttpResponse)~Microsoft.AspNetCore.Http.HttpResponse
+M:System.Web.HttpResponseBase.op_Implicit(Microsoft.AspNetCore.Http.HttpResponse)~System.Web.HttpResponseBase
+M:System.Web.HttpRequestBase.op_Implicit(Microsoft.AspNetCore.Http.HttpRequest)~System.Web.HttpRequestBase
 
 T:Microsoft.AspNetCore.SystemWebAdapters.ISessionState
 T:Microsoft.AspNetCore.SystemWebAdapters.ISessionKeySerializer
 T:Microsoft.AspNetCore.SystemWebAdapters.SessionState.Serialization.ISessionSerializer
+
+# We manually type forward this only for .NET 4.7.2+
+T:System.Web.SameSiteMode

src/Microsoft.AspNetCore.SystemWebAdapters/GenerateApis.targets renamed to src/Microsoft.AspNetCore.SystemWebAdapters/Generated/GenerateApis.targets

@@ -1,17 +1,17 @@
 <Project>
-
   <PropertyGroup>
-    <PlatformNotSupportedMessage>Only support when running on ASP.NET Core or System.Web</PlatformNotSupportedMessage>
+    <PlatformNotSupportedMessage>Only supported when running on ASP.NET Core or System.Web</PlatformNotSupportedMessage>
     <GenerateTypeForwards Condition=" '$(GenerateTypeForwards)' == '' ">false</GenerateTypeForwards>
     <GenerateStandard Condition=" '$(GenerateStandard)' == '' ">false</GenerateStandard>
 
     <__Generate>false</__Generate>
     <__Generate Condition="$(GenerateTypeForwards) OR $(GenerateStandard)">true</__Generate>
 
-    <GenAPITargetPath Condition="$(GenerateTypeForwards)">$(MSBuildProjectDirectory)\TypeForwards.Framework.cs</GenAPITargetPath>
-    <GenAPITargetPath Condition="!$(GenerateTypeForwards)">$(MSBuildProjectDirectory)\Ref.Standard.cs</GenAPITargetPath>
-    <GenAPIAdditionalParameters>-excludeApiList $(MSBuildThisFileDirectory)ExcludedApis.txt -throw "$(PlatformNotSupportedMessage)"</GenAPIAdditionalParameters>
-    <GenAPIAdditionalParameters Condition="$(GenerateTypeForwards)"> -writer TypeForwards</GenAPIAdditionalParameters>
+    <GenAPIHeaderFile>$(MSBuildThisFileDirectory)\Header.txt</GenAPIHeaderFile>
+    <GenAPITargetPath Condition="$(GenerateTypeForwards)">$(MSBuildThisFileDirectory)\TypeForwards.Framework.cs</GenAPITargetPath>
+    <GenAPITargetPath Condition="!$(GenerateTypeForwards)">$(MSBuildThisFileDirectory)\Ref.Standard.cs</GenAPITargetPath>
+    <GenAPIAdditionalParameters>-excludeApiList $(MSBuildThisFileDirectory)ExcludedApis.txt -throw "$(PlatformNotSupportedMessage)" -HeaderFile "$(GenAPIHeaderFile)"</GenAPIAdditionalParameters>
+    <GenAPIAdditionalParameters Condition="$(GenerateTypeForwards)">$(GenAPIAdditionalParameters) -writer TypeForwards</GenAPIAdditionalParameters>
   </PropertyGroup>
 
   <ItemGroup Condition="$(__Generate)">

src/Microsoft.AspNetCore.SystemWebAdapters/Generated/Header.txt

@@ -0,0 +1,18 @@
+// Licensed to the .NET Foundation under one or more agreements.
+// The .NET Foundation licenses this file to you under the MIT license.
+
+#pragma warning disable CA1822 // Mark members as static
+#pragma warning disable CA1010 // Generic interface should also be implemented
+#pragma warning disable CA1055 // URI-like return values should not be strings
+#pragma warning disable CA1710 // Identifiers should have correct suffix
+#pragma warning disable CA1008 // Enums should have zero value
+#pragma warning disable CA1027 // Mark enums with FlagsAttribute
+#pragma warning disable CA1069 // Enums values should not be duplicated
+#pragma warning disable CA1819 // Properties should not return arrays
+#pragma warning disable CA1056 // URI-like properties should not be strings
+#pragma warning disable CA1024 // Use properties where appropriate
+#pragma warning disable CA1724 // Type names should not match namespaces
+#pragma warning disable CA1716 // Using a reserved keyword as the name of a virtual/interface member makes it harder for consumers in other languages to override/implement the member.
+#pragma warning disable CA1054 // URI parameters should not be strings
+#pragma warning disable CS0809 // Obsolete member overrides non-obsolete member
+

src/Microsoft.AspNetCore.SystemWebAdapters/Generated/Ref.Standard.Manual.cs

@@ -0,0 +1,11 @@
+// Licensed to the .NET Foundation under one or more agreements.
+// The .NET Foundation licenses this file to you under the MIT license.
+
+namespace System.Web;
+
+public enum SameSiteMode
+{
+    None = 0,
+    Lax = 1,
+    Strict = 2,
+}