Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coreclr should use the system copy of libunwind for some builds #380

Closed
omajid opened this issue Mar 26, 2018 · 4 comments
Closed

coreclr should use the system copy of libunwind for some builds #380

omajid opened this issue Mar 26, 2018 · 4 comments
Assignees

Comments

@omajid
Copy link
Member

omajid commented Mar 26, 2018

CoreCLR recently got a bundled copy of libunwind (dotnet/coreclr#17094). For source-build, we should look at whether we want portable builds or not (#302) and use that to decide whether we should use the bundled copy of libunwind or the system-installed copy (dotnet/coreclr#17164).

Effectively, once our copy of coreclr is updated, we should pass along -cmakeargs -DCLR_CMAKE_USE_SYSTEM_LIBUNWIND=1 to the coreclr build if PortableBuild is true.

cc @dleeapho @crummel @aslicerh

@dleeapho
Copy link
Contributor

/cc @dseefeld

@omajid
Copy link
Member Author

omajid commented Mar 28, 2018

I opened up dotnet/coreclr#17250 to see if this can be done completely in coreclr itself.

@omajid
Copy link
Member Author

omajid commented Apr 2, 2018

I opened up dotnet/coreclr#17250 to see if this can be done completely in coreclr itself.

It looks like PortableBuild can not be directly associated with the second concept of UseSystemLibraries. It is possible for one to be true but not the other: dotnet/coreclr#17250 (comment)

I will open a PR here to implement the second option directly.

@omajid omajid changed the title coreclr should use the system copy of libunwind for portable builds coreclr should use the system copy of libunwind for some builds Apr 2, 2018
@omajid
Copy link
Member Author

omajid commented Apr 12, 2018

Closing since this was fixed with #391. #416 disables this for Windows.

@omajid omajid closed this as completed Apr 12, 2018
@markwilkie markwilkie added this to the S134 Apr 09 - Apr 27 (4/9/2018) milestone Apr 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants