Skip to content

Commit 7115f94

Browse files
authored
Merge pull request #237 from weshaggard/CleanUpRepoProjs
Remove root ApplyPatches and clean-up dotnetcommmand properties
2 parents 51f2c9a + 7d5fee0 commit 7115f94

19 files changed

+33
-51
lines changed

build.proj

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,6 @@
88
<MSBuild Projects="repos\$(RootRepo).proj" Targets="Build" BuildInParallel="$(BuildInParallel)" />
99
</Target>
1010

11-
<Target Name="ApplyPatches">
12-
<MSBuild Projects="repos\$(RootRepo).proj" Targets="ApplyPatches" BuildInParallel="$(BuildInParallel)" />
13-
</Target>
14-
1511
<Target Name="PrepareOutput">
1612
<MakeDir Directories="$(OutputPath)" />
1713
<MakeDir Directories="$(LoggingDir)" />

dir.props

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,9 @@
5454
<LoggingDir>$(BaseOutputPath)logs/</LoggingDir>
5555
</PropertyGroup>
5656

57+
<!-- Import Build tools common props file where repo-independent properties are found -->
58+
<Import Project="$(ToolsDir)Build.Common.props" Condition="Exists('$(ToolsDir)Build.Common.props')" />
59+
5760
<PropertyGroup>
5861
<ArmEnvironmentVariables Condition="'$(ArmEnvironmentVariables)' == ''">ROOTFS_DIR=$(BaseIntermediatePath)crossrootfs/arm</ArmEnvironmentVariables>
5962
<ArmEnvironmentVariables Condition="'$(Platform)' == 'armel'">ROOTFS_DIR=$(BaseIntermediatePath)crossrootfs/armel</ArmEnvironmentVariables>

repos/application-insights.proj

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,21 +2,20 @@
22
<Project ToolsVersion="15.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
33
<Import Project="$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory), dir.props))/dir.props" />
44
<PropertyGroup>
5-
<DotNetCommand>$(DotNetCliToolDir)dotnet</DotNetCommand>
65
<PackagesOutput>$(ProjectDirectory)/bin/$(Configuration)</PackagesOutput>
76
<RepoApiImplemented>false</RepoApiImplemented>
87
</PropertyGroup>
98

109
<Import Project="$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory), dir.targets))/dir.targets" />
1110

1211
<Target Name="RepoBuild">
13-
<Exec Command="$(DotNetCommand) restore $(ProjectDirectory)/Microsoft.ApplicationInsights.csproj /p:Configuration=$(Configuration) $(RedirectRepoOutputToLog)"
12+
<Exec Command="$(DotnetToolCommand) restore $(ProjectDirectory)/Microsoft.ApplicationInsights.csproj /p:Configuration=$(Configuration) $(RedirectRepoOutputToLog)"
1413
EnvironmentVariables="@(EnvironmentVariables)" />
1514

16-
<Exec Command="$(DotNetCommand) build $(ProjectDirectory)/Microsoft.ApplicationInsights.csproj /p:Configuration=$(Configuration) $(RedirectRepoOutputToLog)"
15+
<Exec Command="$(DotnetToolCommand) build $(ProjectDirectory)/Microsoft.ApplicationInsights.csproj /p:Configuration=$(Configuration) $(RedirectRepoOutputToLog)"
1716
EnvironmentVariables="@(EnvironmentVariables)" />
1817

19-
<Exec Command="$(DotNetCommand) pack $(ProjectDirectory)/Microsoft.ApplicationInsights.csproj /p:Configuration=$(Configuration) $(RedirectRepoOutputToLog)"
18+
<Exec Command="$(DotnetToolCommand) pack $(ProjectDirectory)/Microsoft.ApplicationInsights.csproj /p:Configuration=$(Configuration) $(RedirectRepoOutputToLog)"
2019
EnvironmentVariables="@(EnvironmentVariables)" />
2120
</Target>
2221
</Project>

repos/cli-deps-satellites.proj

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22
<Project ToolsVersion="15.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
33
<Import Project="$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory), dir.props))/dir.props" />
44
<PropertyGroup>
5-
<DotNetCommand>$(DotNetCliToolDir)dotnet</DotNetCommand>
65
<PackagesOutput>$(ProjectDirectory)/bin/$(Configuration)</PackagesOutput>
76
<BuildNumber>20170727-1</BuildNumber>
87
<CommitHash>4ae79a97bb5aadc5486d0f72223bfbf90dd9cfce</CommitHash>
@@ -16,9 +15,9 @@
1615
<Import Project="$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory), dir.targets))/dir.targets" />
1716

1817
<Target Name="RepoBuild">
19-
<Exec Command="$(DotNetCommand) restore $(ProjectDirectory)src $(RedirectRepoOutputToLog)" />
18+
<Exec Command="$(DotnetToolCommand) restore $(ProjectDirectory)src $(RedirectRepoOutputToLog)" />
2019

21-
<Exec Command="$(DotNetCommand) build $(ProjectDirectory)src /v:normal /flp:Verbosity=Diag;LogFile=$(ProjectDirectory)msbuild.log $(RedirectRepoOutputToLog)"
20+
<Exec Command="$(DotnetToolCommand) build $(ProjectDirectory)src /v:normal /flp:Verbosity=Diag;LogFile=$(ProjectDirectory)msbuild.log $(RedirectRepoOutputToLog)"
2221
EnvironmentVariables="@(EnvironmentVariables)" />
2322
</Target>
2423
</Project>

repos/cli-migrate.proj

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22
<Project ToolsVersion="15.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
33
<Import Project="$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory), dir.props))/dir.props" />
44
<PropertyGroup>
5-
<DotNetCommand>$(DotNetCliToolDir)dotnet</DotNetCommand>
65
<PackagesOutput>$(ProjectDirectory)artifacts/packages</PackagesOutput>
76
<CommitCount>2133</CommitCount>
87
<RepoApiImplemented>false</RepoApiImplemented>
@@ -18,7 +17,7 @@
1817
<Import Project="$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory), dir.targets))/dir.targets" />
1918

2019
<Target Name="RepoBuild">
21-
<Exec Command="$(DotNetCommand) msbuild /t:BuildForCli @(MSBuildProperties->'/p:%(Identity)', ' ') $(ProjectDirectory)/build.proj $(RedirectRepoOutputToLog)"
20+
<Exec Command="$(DotnetToolCommand) msbuild /t:BuildForCli @(MSBuildProperties->'/p:%(Identity)', ' ') $(ProjectDirectory)/build.proj $(RedirectRepoOutputToLog)"
2221
EnvironmentVariables="@(EnvironmentVariables)" />
2322
</Target>
2423
</Project>

repos/clicommandlineparser.proj

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,21 +3,20 @@
33
<Import Project="$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory), dir.props))/dir.props" />
44
<PropertyGroup>
55
<CommitCount>167</CommitCount>
6-
<DotNetCommand>$(DotNetCliToolDir)dotnet</DotNetCommand>
76
<PackagesOutput>$(ProjectDirectory)/CommandLine/bin/$(Configuration)/</PackagesOutput>
87
<RepoApiImplemented>false</RepoApiImplemented>
98
</PropertyGroup>
109

1110
<Import Project="$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory), dir.targets))/dir.targets" />
1211

1312
<Target Name="RepoBuild">
14-
<Exec Command="$(DotNetCommand) msbuild /t:MakeVersionProps /p:CommitCount=$(CommitCount) $(ProjectDirectory)/build.proj $(RedirectRepoOutputToLog)"
13+
<Exec Command="$(DotnetToolCommand) msbuild /t:MakeVersionProps /p:CommitCount=$(CommitCount) $(ProjectDirectory)/build.proj $(RedirectRepoOutputToLog)"
1514
EnvironmentVariables="@(EnvironmentVariables)" />
1615

17-
<Exec Command="$(DotNetCommand) restore $(ProjectDirectory)/CommandLine/CommandLine-netcore.csproj $(RedirectRepoOutputToLog)"
16+
<Exec Command="$(DotnetToolCommand) restore $(ProjectDirectory)/CommandLine/CommandLine-netcore.csproj $(RedirectRepoOutputToLog)"
1817
EnvironmentVariables="@(EnvironmentVariables)" />
1918

20-
<Exec Command="$(DotNetCommand) pack /p:Configuration=$(Configuration) $(ProjectDirectory)/CommandLine/CommandLine-netcore.csproj $(RedirectRepoOutputToLog)"
19+
<Exec Command="$(DotnetToolCommand) pack /p:Configuration=$(Configuration) $(ProjectDirectory)/CommandLine/CommandLine-netcore.csproj $(RedirectRepoOutputToLog)"
2120
EnvironmentVariables="@(EnvironmentVariables)" />
2221
</Target>
2322
</Project>

repos/common.proj

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,18 +2,17 @@
22
<Project ToolsVersion="15.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
33
<Import Project="$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory), dir.props))/dir.props" />
44
<PropertyGroup>
5-
<DotNetCommand>$(DotNetCliToolDir)dotnet</DotNetCommand>
65
<PackagesOutput>$(ProjectDirectory)src/Microsoft.Extensions.CommandLineUtils/bin/$(Configuration)/</PackagesOutput>
76
<RepoApiImplemented>false</RepoApiImplemented>
87
</PropertyGroup>
98

109
<Import Project="$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory), dir.targets))/dir.targets" />
1110

1211
<Target Name="RepoBuild">
13-
<Exec Command="$(DotNetCommand) restore $(ProjectDirectory)/src/Microsoft.Extensions.CommandLineUtils/Microsoft.Extensions.CommandLineUtils.csproj $(RedirectRepoOutputToLog)"
12+
<Exec Command="$(DotnetToolCommand) restore $(ProjectDirectory)/src/Microsoft.Extensions.CommandLineUtils/Microsoft.Extensions.CommandLineUtils.csproj $(RedirectRepoOutputToLog)"
1413
EnvironmentVariables="@(EnvironmentVariables)" />
1514

16-
<Exec Command="$(DotNetCommand) pack -c $(Configuration) $(ProjectDirectory)/src/Microsoft.Extensions.CommandLineUtils/Microsoft.Extensions.CommandLineUtils.csproj $(RedirectRepoOutputToLog)"
15+
<Exec Command="$(DotnetToolCommand) pack -c $(Configuration) $(ProjectDirectory)/src/Microsoft.Extensions.CommandLineUtils/Microsoft.Extensions.CommandLineUtils.csproj $(RedirectRepoOutputToLog)"
1716
EnvironmentVariables="@(EnvironmentVariables)" />
1817
</Target>
1918
</Project>

repos/fsharp.proj

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22
<Project ToolsVersion="15.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
33
<Import Project="$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory), dir.props))/dir.props" />
44
<PropertyGroup>
5-
<DotNetCommand>$(DotNetCliToolDir)dotnet</DotNetCommand>
65
<PackagesOutput>$(ProjectDirectory)/BuildFromSource/Release/bin</PackagesOutput>
76
<BuildRevision>170630</BuildRevision>
87
<BuildCommand>$(ProjectDirectory)/src/buildfromsource$(ShellExtension)</BuildCommand>

repos/javascriptservices.proj

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,7 @@
22
<Project ToolsVersion="15.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
33
<Import Project="$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory), dir.props))/dir.props" />
44
<PropertyGroup>
5-
<DotNetCommand>$(DotNetCliToolDir)dotnet</DotNetCommand>
6-
<BuildCommand>$(DotNetCommand) pack -c $(Configuration) --no-build Microsoft.DotNet.Web.Spa.ProjectTemplates.csproj /p:NuspecFile=Microsoft.DotNet.Web.Spa.ProjectTemplates.nuspec</BuildCommand>
5+
<BuildCommand>$(DotnetToolCommand) pack -c $(Configuration) --no-build Microsoft.DotNet.Web.Spa.ProjectTemplates.csproj /p:NuspecFile=Microsoft.DotNet.Web.Spa.ProjectTemplates.nuspec</BuildCommand>
76
<PackagesOutput>$(ProjectDirectory)/bin/$(Configuration)/</PackagesOutput>
87
<RepoApiImplemented>false</RepoApiImplemented>
98
</PropertyGroup>

repos/msbuild.proj

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,16 +2,15 @@
22
<Project ToolsVersion="15.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
33
<Import Project="$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory), dir.props))/dir.props" />
44
<PropertyGroup>
5-
<DotNetCommand>$(DotNetCliToolDir)dotnet</DotNetCommand>
65
<SolutionToBuild>$(ProjectDirectory)/NetCore.sln</SolutionToBuild>
76
<PackagesOutput>$(ProjectDirectory)/bin/$(Configuration)/packages</PackagesOutput>
8-
<BuildCommand>$(DotNetCommand) pack $(SolutionToBuild) /p:Configuration=$(Configuration) /p:PackageOutputPath=$(PackagesOutput)</BuildCommand>
7+
<BuildCommand>$(DotnetToolCommand) pack $(SolutionToBuild) /p:Configuration=$(Configuration) /p:PackageOutputPath=$(PackagesOutput)</BuildCommand>
98
<RepoApiImplemented>false</RepoApiImplemented>
109
</PropertyGroup>
1110

1211
<Target Name="RestoreSolution"
1312
BeforeTargets="Build">
14-
<Exec Command="$(DotNetCommand) restore $(SolutionToBuild) $(RedirectRepoOutputToLog)"
13+
<Exec Command="$(DotnetToolCommand) restore $(SolutionToBuild) $(RedirectRepoOutputToLog)"
1514
WorkingDirectory="$(ProjectDirectory)"
1615
EnvironmentVariables="@(EnvironmentVariables)" />
1716
</Target>

0 commit comments

Comments
 (0)