From 3f2519ffdad03208fb640897aa65132a9af2ef09 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Fri, 6 Mar 2026 17:24:56 +0000 Subject: [PATCH 1/3] Port PR #52743: Remove ResolverTargetFramework and ToolsetTargetFramework, use SdkTargetFramework directly Co-authored-by: marcpopMSFT <12663534+marcpopMSFT@users.noreply.github.com> --- Directory.Build.props | 4 --- .../Microsoft.DotNet.Cli.Utils.csproj | 2 +- .../Microsoft.DotNet.Cli.Utils/Polyfills.cs | 2 +- ...initions.cs => netframeworkDefinitions.cs} | 0 src/Layout/redist/targets/Crossgen.targets | 2 +- .../Microsoft.DotNet.TemplateLocator.csproj | 4 +-- .../Microsoft.DotNet.NativeWrapper.csproj | 2 +- .../Microsoft.DotNet.SdkResolver.csproj | 4 +-- ....NET.Sdk.WorkloadMSBuildSdkResolver.csproj | 2 +- ...soft.NET.Sdk.WorkloadManifestReader.csproj | 2 +- .../Tasks/Data/StaticWebAsset.cs | 2 +- .../Tasks/Data/StaticWebAssetEndpoint.cs | 4 +-- .../Data/StaticWebAssetEndpointProperty.cs | 2 +- .../StaticWebAssetEndpointResponseHeader.cs | 2 +- .../Publish/Tasks/MsDeploy/CommonUtility.cs | 32 +++++++++---------- .../Publish/Tasks/MsDeploy/DynamicAssembly.cs | 8 ++--- .../Tasks/MsDeploy/VsMSDeployObject.cs | 4 +-- .../Tasks/MsDeploy/CreateManifestFile.cs | 2 +- .../Tasks/MsDeploy/CreateParameterFile.cs | 2 +- .../Publish/Tasks/Tasks/MsDeploy/MSDeploy.cs | 4 +-- .../Tasks/Tasks/MsDeploy/VsMsdeploy.cs | 16 +++++----- .../ArgumentForwarding.Tests.csproj | 2 +- .../ArgumentsReflector.csproj | 2 +- test/EndToEnd.Tests/EndToEnd.Tests.csproj | 2 +- ...t.DotNet.ApiCompat.IntegrationTests.csproj | 4 +-- .../Microsoft.DotNet.ApiCompat.Tests.csproj | 6 ++-- ...osoft.DotNet.ApiCompatibility.Tests.csproj | 4 +-- .../Microsoft.DotNet.ApiDiff.Tests.csproj | 2 +- ...ft.DotNet.ApiSymbolExtensions.Tests.csproj | 4 +-- .../Microsoft.DotNet.Cli.Utils.Tests.csproj | 2 +- .../Microsoft.DotNet.GenAPI.Tests.csproj | 4 +-- ...crosoft.DotNet.PackageInstall.Tests.csproj | 2 +- ...soft.DotNet.PackageValidation.Tests.csproj | 4 +-- ...rosoft.DotNet.TemplateLocator.Tests.csproj | 8 ++--- ...t.DotNet.Tools.Tests.ComponentMocks.csproj | 2 +- ...crosoft.NET.Sdk.Publish.Tasks.Tests.csproj | 6 ++-- ...ET.Sdk.WorkloadManifestReader.Tests.csproj | 6 ++-- .../Microsoft.Win32.Msi.Manual.Tests.csproj | 4 +-- .../Microsoft.Win32.Msi.Tests.csproj | 6 ++-- .../Msbuild.Tests.Utilities.csproj | 2 +- test/SDDLTests/SDDLTests.csproj | 4 +-- .../dotnet-new.IntegrationTests.csproj | 2 +- .../dotnet-watch-test-browser.csproj | 2 +- .../dotnet-watch.Tests.csproj | 2 +- test/dotnet.Tests/dotnet.Tests.csproj | 2 +- .../msbuild.Integration.Tests.csproj | 2 +- test/sdk-tasks.Tests/sdk-tasks.Tests.csproj | 6 ++-- .../trustedroots.Tests.csproj | 2 +- 48 files changed, 96 insertions(+), 100 deletions(-) rename src/Containers/Microsoft.NET.Build.Containers/{net472Definitions.cs => netframeworkDefinitions.cs} (100%) diff --git a/Directory.Build.props b/Directory.Build.props index 7816170a7988..075acf2ffa0c 100644 --- a/Directory.Build.props +++ b/Directory.Build.props @@ -50,13 +50,9 @@ net10.0 $(NetCurrent) - $(SdkTargetFramework) net9.0 net472 - - $(SdkTargetFramework) - diff --git a/src/Cli/Microsoft.DotNet.Cli.Utils/Microsoft.DotNet.Cli.Utils.csproj b/src/Cli/Microsoft.DotNet.Cli.Utils/Microsoft.DotNet.Cli.Utils.csproj index 211355e6cfdf..ff5e9271dda7 100644 --- a/src/Cli/Microsoft.DotNet.Cli.Utils/Microsoft.DotNet.Cli.Utils.csproj +++ b/src/Cli/Microsoft.DotNet.Cli.Utils/Microsoft.DotNet.Cli.Utils.csproj @@ -1,6 +1,6 @@  - $(ResolverTargetFramework);net472 + $(SdkTargetFramework);net472 true MicrosoftAspNetCore true diff --git a/src/Cli/Microsoft.DotNet.Cli.Utils/Polyfills.cs b/src/Cli/Microsoft.DotNet.Cli.Utils/Polyfills.cs index 59668dbae394..af29e1721a34 100644 --- a/src/Cli/Microsoft.DotNet.Cli.Utils/Polyfills.cs +++ b/src/Cli/Microsoft.DotNet.Cli.Utils/Polyfills.cs @@ -1,7 +1,7 @@ // Licensed to the .NET Foundation under one or more agreements. // The .NET Foundation licenses this file to you under the MIT license. -#if NET472 +#if NETFRAMEWORK #pragma warning disable IDE0130 // Namespace does not match folder structure namespace System.Runtime.CompilerServices { diff --git a/src/Containers/Microsoft.NET.Build.Containers/net472Definitions.cs b/src/Containers/Microsoft.NET.Build.Containers/netframeworkDefinitions.cs similarity index 100% rename from src/Containers/Microsoft.NET.Build.Containers/net472Definitions.cs rename to src/Containers/Microsoft.NET.Build.Containers/netframeworkDefinitions.cs diff --git a/src/Layout/redist/targets/Crossgen.targets b/src/Layout/redist/targets/Crossgen.targets index 3e07f481af11..f28b268274c6 100644 --- a/src/Layout/redist/targets/Crossgen.targets +++ b/src/Layout/redist/targets/Crossgen.targets @@ -66,7 +66,7 @@ - + diff --git a/src/Microsoft.DotNet.TemplateLocator/Microsoft.DotNet.TemplateLocator.csproj b/src/Microsoft.DotNet.TemplateLocator/Microsoft.DotNet.TemplateLocator.csproj index 9e78f55cad3c..9b652c8cbf84 100644 --- a/src/Microsoft.DotNet.TemplateLocator/Microsoft.DotNet.TemplateLocator.csproj +++ b/src/Microsoft.DotNet.TemplateLocator/Microsoft.DotNet.TemplateLocator.csproj @@ -1,10 +1,10 @@  - $(ResolverTargetFramework);net472 + $(SdkTargetFramework);net472 - $(ResolverTargetFramework) + $(SdkTargetFramework) MicrosoftAspNetCore true diff --git a/src/Resolvers/Microsoft.DotNet.NativeWrapper/Microsoft.DotNet.NativeWrapper.csproj b/src/Resolvers/Microsoft.DotNet.NativeWrapper/Microsoft.DotNet.NativeWrapper.csproj index f39d5b24e2c2..ec780cd24208 100644 --- a/src/Resolvers/Microsoft.DotNet.NativeWrapper/Microsoft.DotNet.NativeWrapper.csproj +++ b/src/Resolvers/Microsoft.DotNet.NativeWrapper/Microsoft.DotNet.NativeWrapper.csproj @@ -1,7 +1,7 @@  - $(ResolverTargetFramework);net472 + $(SdkTargetFramework);net472 diff --git a/src/Resolvers/Microsoft.DotNet.SdkResolver/Microsoft.DotNet.SdkResolver.csproj b/src/Resolvers/Microsoft.DotNet.SdkResolver/Microsoft.DotNet.SdkResolver.csproj index 3de0d9656c3f..bab77ee1d360 100644 --- a/src/Resolvers/Microsoft.DotNet.SdkResolver/Microsoft.DotNet.SdkResolver.csproj +++ b/src/Resolvers/Microsoft.DotNet.SdkResolver/Microsoft.DotNet.SdkResolver.csproj @@ -1,10 +1,10 @@  - $(ResolverTargetFramework);net472 + $(SdkTargetFramework);net472 - $(ResolverTargetFramework) + $(SdkTargetFramework) true Microsoft.DotNet.DotNetSdkResolver diff --git a/src/Resolvers/Microsoft.NET.Sdk.WorkloadMSBuildSdkResolver/Microsoft.NET.Sdk.WorkloadMSBuildSdkResolver.csproj b/src/Resolvers/Microsoft.NET.Sdk.WorkloadMSBuildSdkResolver/Microsoft.NET.Sdk.WorkloadMSBuildSdkResolver.csproj index 5e0bdda9834a..d6532a3bdd7c 100644 --- a/src/Resolvers/Microsoft.NET.Sdk.WorkloadMSBuildSdkResolver/Microsoft.NET.Sdk.WorkloadMSBuildSdkResolver.csproj +++ b/src/Resolvers/Microsoft.NET.Sdk.WorkloadMSBuildSdkResolver/Microsoft.NET.Sdk.WorkloadMSBuildSdkResolver.csproj @@ -1,7 +1,7 @@  - $(ResolverTargetFramework) + $(SdkTargetFramework) true diff --git a/src/Resolvers/Microsoft.NET.Sdk.WorkloadManifestReader/Microsoft.NET.Sdk.WorkloadManifestReader.csproj b/src/Resolvers/Microsoft.NET.Sdk.WorkloadManifestReader/Microsoft.NET.Sdk.WorkloadManifestReader.csproj index db045f7e4b59..d676c7e0b230 100644 --- a/src/Resolvers/Microsoft.NET.Sdk.WorkloadManifestReader/Microsoft.NET.Sdk.WorkloadManifestReader.csproj +++ b/src/Resolvers/Microsoft.NET.Sdk.WorkloadManifestReader/Microsoft.NET.Sdk.WorkloadManifestReader.csproj @@ -1,7 +1,7 @@  - $(ResolverTargetFramework);net472 + $(SdkTargetFramework);net472 MicrosoftAspNetCore true diff --git a/src/StaticWebAssetsSdk/Tasks/Data/StaticWebAsset.cs b/src/StaticWebAssetsSdk/Tasks/Data/StaticWebAsset.cs index 60058355f0b6..78966129d04f 100644 --- a/src/StaticWebAssetsSdk/Tasks/Data/StaticWebAsset.cs +++ b/src/StaticWebAssetsSdk/Tasks/Data/StaticWebAsset.cs @@ -752,7 +752,7 @@ public void Normalize() // * Appends a trailing directory separator at the end. public static string NormalizeContentRootPath(string path) => Path.GetFullPath(path) + - // We need to do .ToString because there is no EndsWith overload for chars in .net472 + // We need to do .ToString because there is no EndsWith overload for chars in .NET Framework (path.EndsWith(Path.DirectorySeparatorChar.ToString()), path.EndsWith(Path.AltDirectorySeparatorChar.ToString())) switch { (true, _) => "", diff --git a/src/StaticWebAssetsSdk/Tasks/Data/StaticWebAssetEndpoint.cs b/src/StaticWebAssetsSdk/Tasks/Data/StaticWebAssetEndpoint.cs index 80cfe3b4c417..a101abad250d 100644 --- a/src/StaticWebAssetsSdk/Tasks/Data/StaticWebAssetEndpoint.cs +++ b/src/StaticWebAssetsSdk/Tasks/Data/StaticWebAssetEndpoint.cs @@ -237,7 +237,7 @@ public bool Equals(StaticWebAssetEndpoint other) => other is not null && Route = public override int GetHashCode() { -#if NET472_OR_GREATER +#if NETFRAMEWORK var hashCode = -604019124; hashCode = hashCode * -1521134295 + EqualityComparer.Default.GetHashCode(Route); hashCode = hashCode * -1521134295 + EqualityComparer.Default.GetHashCode(AssetFile); @@ -403,7 +403,7 @@ public bool Equals(StaticWebAssetEndpoint x, StaticWebAssetEndpoint y) public int GetHashCode(StaticWebAssetEndpoint obj) { -#if NET472_OR_GREATER +#if NETFRAMEWORK var hashCode = -604019124; hashCode = hashCode * -1521134295 + EqualityComparer.Default.GetHashCode(obj.Route); hashCode = hashCode * -1521134295 + EqualityComparer.Default.GetHashCode(obj.AssetFile); diff --git a/src/StaticWebAssetsSdk/Tasks/Data/StaticWebAssetEndpointProperty.cs b/src/StaticWebAssetsSdk/Tasks/Data/StaticWebAssetEndpointProperty.cs index 5110d7e36d54..9c308d451a68 100644 --- a/src/StaticWebAssetsSdk/Tasks/Data/StaticWebAssetEndpointProperty.cs +++ b/src/StaticWebAssetsSdk/Tasks/Data/StaticWebAssetEndpointProperty.cs @@ -41,7 +41,7 @@ public bool Equals(StaticWebAssetEndpointProperty other) => public override int GetHashCode() { -#if NET472_OR_GREATER +#if NETFRAMEWORK var hashCode = -244751520; hashCode = hashCode * -1521134295 + EqualityComparer.Default.GetHashCode(Name); hashCode = hashCode * -1521134295 + EqualityComparer.Default.GetHashCode(Value); diff --git a/src/StaticWebAssetsSdk/Tasks/Data/StaticWebAssetEndpointResponseHeader.cs b/src/StaticWebAssetsSdk/Tasks/Data/StaticWebAssetEndpointResponseHeader.cs index 8ca2af0a1f5b..232065651ec2 100644 --- a/src/StaticWebAssetsSdk/Tasks/Data/StaticWebAssetEndpointResponseHeader.cs +++ b/src/StaticWebAssetsSdk/Tasks/Data/StaticWebAssetEndpointResponseHeader.cs @@ -36,7 +36,7 @@ public bool Equals(StaticWebAssetEndpointResponseHeader other) => string.Equals( public override int GetHashCode() { -#if NET472_OR_GREATER +#if NETFRAMEWORK var hashCode = -244751520; hashCode = hashCode * -1521134295 + EqualityComparer.Default.GetHashCode(Name); hashCode = hashCode * -1521134295 + EqualityComparer.Default.GetHashCode(Value); diff --git a/src/WebSdk/Publish/Tasks/MsDeploy/CommonUtility.cs b/src/WebSdk/Publish/Tasks/MsDeploy/CommonUtility.cs index 1a78ef754d58..78f5d8e45851 100644 --- a/src/WebSdk/Publish/Tasks/MsDeploy/CommonUtility.cs +++ b/src/WebSdk/Publish/Tasks/MsDeploy/CommonUtility.cs @@ -339,7 +339,7 @@ public static StringBuilder CleanStringBuilder } } -#if NET472 +#if NETFRAMEWORK /// /// Return the current machine's IIS version /// @@ -440,7 +440,7 @@ public static bool CheckMSDeploymentVersion(Utilities.TaskLoggingHelper log, out /// public static void SaveDocument(XmlDocument document, string outputFileName, Encoding encode) { -#if NET472 +#if NETFRAMEWORK XmlTextWriter textWriter = new(outputFileName, encode) { Formatting = Formatting.Indented @@ -487,7 +487,7 @@ private static bool CheckMSDeploymentVersion() currentMinVersion = new Version(7, 1, 614); // current drop { string strMinimumVersion = string.Empty; -#if NET472 +#if NETFRAMEWORK using (Win32.RegistryKey registryKeyVs = Win32.Registry.CurrentUser.OpenSubKey(@"SOFTWARE\Microsoft\VisualStudio\11.0\WebDeploy")) { if (registryKeyVs != null) @@ -544,7 +544,7 @@ private static bool CheckMSDeploymentVersion() } else { -#if NET472 +#if NETFRAMEWORK _strErrorMessage = string.Format(CultureInfo.CurrentCulture, Resources.VSMSDEPLOY_MSDEPLOYLOADFAIL, Resources.VSMSDEPLOY_MSDEPLOY32bit, Resources.VSMSDEPLOY_MSDEPLOY64bit, @@ -561,7 +561,7 @@ private static bool CheckMSDeploymentVersion() } } -#if NET472 +#if NETFRAMEWORK /// /// Return a search path for the data /// @@ -605,7 +605,7 @@ internal static void BuildArgumentsBaseOnEnumTypeName(Framework.ITaskItem item, if (!string.IsNullOrEmpty(data)) { string valueData = PutValueInQuote(data, valueQuote); -#if NET472 +#if NETFRAMEWORK arguments.Add(string.Concat(enumName.ToLower(CultureInfo.InvariantCulture), "=", valueData)); #else arguments.Add(string.Concat(enumName.ToLower(), "=", valueData)); @@ -684,7 +684,7 @@ public static void MsDeployExeEndOfExecuteMessage(bool bSuccess, string destType string[] ArchiveDirOnly = new string[] { MSDeploy.Provider.ArchiveDir }; if (bSuccess) { -#if NET472 +#if NETFRAMEWORK if (IsOneOf(destType, packageArchivedir, StringComparison.InvariantCultureIgnoreCase)) #else if (IsOneOf(destType, packageArchivedir, StringComparison.OrdinalIgnoreCase)) @@ -695,7 +695,7 @@ public static void MsDeployExeEndOfExecuteMessage(bool bSuccess, string destType string dir = Path.GetDirectoryName(destRoot) ?? string.Empty; string dirUri = ConvertAbsPhysicalPathToAbsUriPath(dir); -#if NET472 +#if NETFRAMEWORK if (IsOneOf(destType, ArchiveDirOnly, StringComparison.InvariantCultureIgnoreCase)) #else if (IsOneOf(destType, ArchiveDirOnly, StringComparison.OrdinalIgnoreCase)) @@ -712,7 +712,7 @@ public static void MsDeployExeEndOfExecuteMessage(bool bSuccess, string destType } else { -#if NET472 +#if NETFRAMEWORK if (IsOneOf(destType, packageArchivedir, StringComparison.InvariantCultureIgnoreCase)) #else if (IsOneOf(destType, packageArchivedir, StringComparison.OrdinalIgnoreCase)) @@ -745,7 +745,7 @@ public static void MsDeployEndOfExecuteMessage(bool bSuccess, string destType, s // Deployment.DeploymentWellKnownProvider wellKnownProvider = Deployment.DeploymentWellKnownProvider.Unknown; Type? DeploymentWellKnownProviderType = MSWebDeploymentAssembly.DynamicAssembly?.GetType(MSDeploy.TypeName.DeploymentWellKnownProvider); dynamic? wellKnownProvider = MSWebDeploymentAssembly.DynamicAssembly?.GetEnumValue(MSDeploy.TypeName.DeploymentWellKnownProvider, "Unknown"); -#if NET472 +#if NETFRAMEWORK if (string.Compare(destType, MSDeploy.Provider.DbDacFx, StringComparison.InvariantCultureIgnoreCase) != 0) #else if (string.Compare(destType, MSDeploy.Provider.DbDacFx, StringComparison.OrdinalIgnoreCase) != 0) @@ -1337,7 +1337,7 @@ public static string DumpITaskItem(Framework.ITaskItem iTaskItem) public static bool IsDeploymentWellKnownProvider(string strProvider) { -#if NET472 +#if NETFRAMEWORK if (string.Compare(strProvider, MSDeploy.Provider.DbDacFx, StringComparison.InvariantCultureIgnoreCase) == 0) #else if (string.Compare(strProvider, MSDeploy.Provider.DbDacFx, StringComparison.OrdinalIgnoreCase) == 0) @@ -1513,7 +1513,7 @@ static int ContainMsdeployFwlink(string errorMessage, out string? provider) internal static bool IsType(Type type, Type? checkType) { -#if NET472 +#if NETFRAMEWORK if (checkType != null && (type == checkType || type.IsSubclassOf(checkType))) { return true; @@ -1566,7 +1566,7 @@ internal static void LogVsMsDeployException(Utilities.TaskLoggingHelper Log, Exc lastDeploymentException = rootException; } -#if NET472 +#if NETFRAMEWORK bool isWebException = rootException is System.Net.WebException; if (isWebException) { @@ -1820,7 +1820,7 @@ internal static void SetupMSWebDeployDynamicAssemblies(string? strVersionsToTry, MSWebDeploymentAssembly.SetVersion(version); Version webDelegationAssemblyVersion = version; -#if NET472 +#if NETFRAMEWORK if (MSWebDeploymentAssembly.DynamicAssembly != null && MSWebDeploymentAssembly.DynamicAssembly.Assembly != null) { foreach (AssemblyName assemblyName in MSWebDeploymentAssembly.DynamicAssembly.Assembly.GetReferencedAssemblies()) @@ -1894,7 +1894,7 @@ internal static void SetupMSWebDeployDynamicAssemblies(string? strVersionsToTry, /// public static string? GetFullUserAgentString(string? userAgent) { -#if NET472 +#if NETFRAMEWORK if(string.IsNullOrEmpty(userAgent)) return null; try @@ -1920,7 +1920,7 @@ internal static class ItemFilter public static bool ItemFilterPipelineMetadata(Framework.ITaskItem item, string metadataName, string metadataValue, bool fIgnoreCase) { -#if NET472 +#if NETFRAMEWORK return (string.Compare(item.GetMetadata(metadataName), metadataValue, fIgnoreCase, CultureInfo.InvariantCulture) == 0); #else return (string.Compare(item.GetMetadata(metadataName), metadataValue, fIgnoreCase) == 0); diff --git a/src/WebSdk/Publish/Tasks/MsDeploy/DynamicAssembly.cs b/src/WebSdk/Publish/Tasks/MsDeploy/DynamicAssembly.cs index 6c99f9d51d06..dfa0b25e555e 100644 --- a/src/WebSdk/Publish/Tasks/MsDeploy/DynamicAssembly.cs +++ b/src/WebSdk/Publish/Tasks/MsDeploy/DynamicAssembly.cs @@ -12,7 +12,7 @@ internal class DynamicAssembly public DynamicAssembly(string assemblyName, Version verToLoad, string publicKeyToken) { AssemblyFullName = string.Format(System.Globalization.CultureInfo.CurrentCulture, "{0}, Version={1}.{2}.0.0, Culture=neutral, PublicKeyToken={3}", assemblyName, verToLoad.Major, verToLoad.Minor, publicKeyToken); -#if NET472 +#if NETFRAMEWORK bool isAssemblyLoaded = false; try { @@ -32,7 +32,7 @@ public DynamicAssembly(string assemblyName, Version verToLoad, string publicKeyT Version = verToLoad; } -#if NET472 +#if NETFRAMEWORK public static string TaskAssemblyDirectory { get @@ -133,7 +133,7 @@ public bool TryGetEnumValue(string enumTypeName, string enumStrValue, out object return createdObject; } -#if NET472 +#if NETFRAMEWORK public object? CallStaticMethod(string typeName, string methodName, object[] arguments) { Type? t = GetType(typeName); @@ -163,7 +163,7 @@ public bool TryGetEnumValue(string enumTypeName, string enumStrValue, out object MethodCallExpression body = Expression.Call(Expression.Constant(d), invokeMethod, parameters); var lambda = Expression.Lambda(body, parameters); // Diagnostics.Debug.Assert(false, lambda.ToString()); -#if NET472 +#if NETFRAMEWORK return Delegate.CreateDelegate(handlerType, lambda.Compile(), "Invoke", false); #else return null; diff --git a/src/WebSdk/Publish/Tasks/MsDeploy/VsMSDeployObject.cs b/src/WebSdk/Publish/Tasks/MsDeploy/VsMSDeployObject.cs index 33dca06a48e3..a49234edf7a0 100644 --- a/src/WebSdk/Publish/Tasks/MsDeploy/VsMSDeployObject.cs +++ b/src/WebSdk/Publish/Tasks/MsDeploy/VsMSDeployObject.cs @@ -231,7 +231,7 @@ public VSMSDeployObject(string provider, string root) // maybe we should show the "secure data to display" // for now just suppress it. -#if NET472 +#if NETFRAMEWORK if (0 == string.Compare(m_provider, MSWebDeploymentAssembly.DynamicAssembly?.GetEnumValue(MSDeploy.TypeName.DeploymentWellKnownProvider, MSDeploy.Provider.DBFullSql)?.ToString(), StringComparison.InvariantCultureIgnoreCase) || 0 == string.Compare(m_provider, MSDeploy.Provider.DbDacFx , StringComparison.InvariantCultureIgnoreCase)) m_fNoDisplayRoot = true; @@ -555,7 +555,7 @@ public void ResetBaseOptions() public void SyncTo(VSMSDeployObject destObject, /*VSMSDeploySyncOption*/ dynamic syncOptions, IVSMSDeployHost _host) { -#if NET472 +#if NETFRAMEWORK //$BUGBUG lmchen, there is only set to source provider? // set up the provider setting /*Deployment.DeploymentProviderOptions*/ diff --git a/src/WebSdk/Publish/Tasks/Tasks/MsDeploy/CreateManifestFile.cs b/src/WebSdk/Publish/Tasks/Tasks/MsDeploy/CreateManifestFile.cs index 73cea04ee17d..8451519fe87a 100644 --- a/src/WebSdk/Publish/Tasks/Tasks/MsDeploy/CreateManifestFile.cs +++ b/src/WebSdk/Publish/Tasks/Tasks/MsDeploy/CreateManifestFile.cs @@ -110,7 +110,7 @@ public override bool Execute() WriteManifestsToFile(Log, m_manifests, ManifestFile); } } -#if NET472 +#if NETFRAMEWORK catch (Xml.XmlException ex) { Uri sourceUri = new(ex.SourceUri); diff --git a/src/WebSdk/Publish/Tasks/Tasks/MsDeploy/CreateParameterFile.cs b/src/WebSdk/Publish/Tasks/Tasks/MsDeploy/CreateParameterFile.cs index 7205f19029b8..11e01a0d52eb 100644 --- a/src/WebSdk/Publish/Tasks/Tasks/MsDeploy/CreateParameterFile.cs +++ b/src/WebSdk/Publish/Tasks/Tasks/MsDeploy/CreateParameterFile.cs @@ -307,7 +307,7 @@ public override bool Execute() } } } -#if NET472 +#if NETFRAMEWORK catch (Xml.XmlException ex) { Uri sourceUri = new(ex.SourceUri); diff --git a/src/WebSdk/Publish/Tasks/Tasks/MsDeploy/MSDeploy.cs b/src/WebSdk/Publish/Tasks/Tasks/MsDeploy/MSDeploy.cs index 0f703a82678f..b61a8d15e1bd 100644 --- a/src/WebSdk/Publish/Tasks/Tasks/MsDeploy/MSDeploy.cs +++ b/src/WebSdk/Publish/Tasks/Tasks/MsDeploy/MSDeploy.cs @@ -225,7 +225,7 @@ public string? ExePath { get { -#if NET472 +#if NETFRAMEWORK if (string.IsNullOrEmpty(m_exePath)) { // if path is not set, we optimize to latest version of msdeploy @@ -796,7 +796,7 @@ public static void AddSetParametersToObject(Utilities.CommandLineBuilder command Utility.BuildArgumentsBaseOnEnumTypeName(item, arguments, typeof(ExistingDeclareParameterMetadata), valueQuote); if (arguments.Count > 0 && !string.IsNullOrEmpty(data)) { -#if NET472 +#if NETFRAMEWORK arguments.Add(string.Concat(ExistingSyncParameterMetadata.Value.ToString().ToLower(CultureInfo.InvariantCulture), "=", Utility.PutValueInQuote(data, valueQuote))); #else diff --git a/src/WebSdk/Publish/Tasks/Tasks/MsDeploy/VsMsdeploy.cs b/src/WebSdk/Publish/Tasks/Tasks/MsDeploy/VsMsdeploy.cs index ede99a2cbe10..cccd735c2c6f 100644 --- a/src/WebSdk/Publish/Tasks/Tasks/MsDeploy/VsMsdeploy.cs +++ b/src/WebSdk/Publish/Tasks/Tasks/MsDeploy/VsMsdeploy.cs @@ -166,7 +166,7 @@ private bool CancelCallback() if (_option == null) { object? option = MSWebDeploymentAssembly.DynamicAssembly?.CreateObject("Microsoft.Web.Deployment.DeploymentSyncOptions"); -#if NET472 +#if NETFRAMEWORK Type? deploymentCancelCallbackType = MSWebDeploymentAssembly.DynamicAssembly?.GetType("Microsoft.Web.Deployment.DeploymentCancelCallback"); object cancelCallbackDelegate = Delegate.CreateDelegate(deploymentCancelCallbackType, this, "CancelCallback"); @@ -180,7 +180,7 @@ private bool CancelCallback() return _option; } -#if NET472 +#if NETFRAMEWORK private Dictionary? _highImportanceEventTypes = null; private Dictionary GetHighImportanceEventTypes() { @@ -204,7 +204,7 @@ void TraceEventHandlerDynamic(object sender, dynamic e) // throw new System.NotImplementedException(); string msg = e.Message; Diagnostics.Trace.WriteLine("MSDeploy TraceEvent Handler is called with " + msg); -#if NET472 +#if NETFRAMEWORK LogTrace(e, GetHighImportanceEventTypes()); #endif //try @@ -329,7 +329,7 @@ public static BaseMSDeployDriver CreateBaseMSDeployDriver( /// We create CustomBuildWithPropertiesEventArgs is for the purpose of logging verious information /// in a IDictionary such that the MBuild handler can handle generically. /// -#if NET472 +#if NETFRAMEWORK [Serializable] #endif public class CustomBuildWithPropertiesEventArgs : CustomBuildEventArgs, Collections.IDictionary @@ -447,7 +447,7 @@ protected override void BeforeSync() // Utility function to log all public instance property to CustomerBuildEventArgs private static void AddAllPropertiesToCustomBuildWithPropertyEventArgs(ExtendedCustomBuildEventArgs cbpEventArg, object obj) { -#if NET472 +#if NETFRAMEWORK if (obj != null) { Type thisType = obj.GetType(); @@ -776,7 +776,7 @@ private bool AllowUntrustedCertCallback(object sp, } private void SetupPublishRelatedProperties(ref VSMSDeployObject dest) { -#if NET472 +#if NETFRAMEWORK if (AllowUntrustedCertificate) { System.Net.ServicePointManager.ServerCertificateValidationCallback @@ -885,7 +885,7 @@ public override bool Execute() } finally { -#if NET472 +#if NETFRAMEWORK if (AllowUntrustedCertificate) System.Net.ServicePointManager.ServerCertificateValidationCallback @@ -1089,7 +1089,7 @@ public void Cancel() public object? GetProperty(string propertyName) { -#if NET472 +#if NETFRAMEWORK string lowerName = propertyName.ToLower(System.Globalization.CultureInfo.InvariantCulture); #else string lowerName = propertyName.ToLower(); diff --git a/test/ArgumentForwarding.Tests/ArgumentForwarding.Tests.csproj b/test/ArgumentForwarding.Tests/ArgumentForwarding.Tests.csproj index fb2419eebf04..2cf683724c71 100644 --- a/test/ArgumentForwarding.Tests/ArgumentForwarding.Tests.csproj +++ b/test/ArgumentForwarding.Tests/ArgumentForwarding.Tests.csproj @@ -1,7 +1,7 @@  - $(ToolsetTargetFramework) + $(SdkTargetFramework) Exe false true diff --git a/test/ArgumentsReflector/ArgumentsReflector.csproj b/test/ArgumentsReflector/ArgumentsReflector.csproj index d34fdf938aa6..fadc4185321c 100644 --- a/test/ArgumentsReflector/ArgumentsReflector.csproj +++ b/test/ArgumentsReflector/ArgumentsReflector.csproj @@ -1,7 +1,7 @@  - $(ToolsetTargetFramework) + $(SdkTargetFramework) Exe diff --git a/test/EndToEnd.Tests/EndToEnd.Tests.csproj b/test/EndToEnd.Tests/EndToEnd.Tests.csproj index 6dbf926e6108..505e8f4b0633 100644 --- a/test/EndToEnd.Tests/EndToEnd.Tests.csproj +++ b/test/EndToEnd.Tests/EndToEnd.Tests.csproj @@ -6,7 +6,7 @@ - $(ToolsetTargetFramework) + $(SdkTargetFramework) Exe false diff --git a/test/Microsoft.DotNet.ApiCompat.IntegrationTests/Microsoft.DotNet.ApiCompat.IntegrationTests.csproj b/test/Microsoft.DotNet.ApiCompat.IntegrationTests/Microsoft.DotNet.ApiCompat.IntegrationTests.csproj index 48ca6c84d0de..8c17bb602b57 100644 --- a/test/Microsoft.DotNet.ApiCompat.IntegrationTests/Microsoft.DotNet.ApiCompat.IntegrationTests.csproj +++ b/test/Microsoft.DotNet.ApiCompat.IntegrationTests/Microsoft.DotNet.ApiCompat.IntegrationTests.csproj @@ -1,8 +1,8 @@  - $(ToolsetTargetFramework);$(NetFrameworkToolCurrent) - Exe + $(SdkTargetFramework);$(NetFrameworkToolCurrent) + Exe true diff --git a/test/Microsoft.DotNet.ApiCompat.Tests/Microsoft.DotNet.ApiCompat.Tests.csproj b/test/Microsoft.DotNet.ApiCompat.Tests/Microsoft.DotNet.ApiCompat.Tests.csproj index bac201f78cea..27745efcdfef 100644 --- a/test/Microsoft.DotNet.ApiCompat.Tests/Microsoft.DotNet.ApiCompat.Tests.csproj +++ b/test/Microsoft.DotNet.ApiCompat.Tests/Microsoft.DotNet.ApiCompat.Tests.csproj @@ -1,9 +1,9 @@  - $(ToolsetTargetFramework);$(NetFrameworkToolCurrent) - $(ToolsetTargetFramework) - Exe + $(SdkTargetFramework);$(NetFrameworkToolCurrent) + $(SdkTargetFramework) + Exe true diff --git a/test/Microsoft.DotNet.ApiCompatibility.Tests/Microsoft.DotNet.ApiCompatibility.Tests.csproj b/test/Microsoft.DotNet.ApiCompatibility.Tests/Microsoft.DotNet.ApiCompatibility.Tests.csproj index e2c0ccd07842..aa1bdc4bcf96 100644 --- a/test/Microsoft.DotNet.ApiCompatibility.Tests/Microsoft.DotNet.ApiCompatibility.Tests.csproj +++ b/test/Microsoft.DotNet.ApiCompatibility.Tests/Microsoft.DotNet.ApiCompatibility.Tests.csproj @@ -1,8 +1,8 @@  - $(ToolsetTargetFramework);$(NetFrameworkToolCurrent) - Exe + $(SdkTargetFramework);$(NetFrameworkToolCurrent) + Exe true diff --git a/test/Microsoft.DotNet.ApiDiff.Tests/Microsoft.DotNet.ApiDiff.Tests.csproj b/test/Microsoft.DotNet.ApiDiff.Tests/Microsoft.DotNet.ApiDiff.Tests.csproj index 0614262e2f1e..bc07041bee3e 100644 --- a/test/Microsoft.DotNet.ApiDiff.Tests/Microsoft.DotNet.ApiDiff.Tests.csproj +++ b/test/Microsoft.DotNet.ApiDiff.Tests/Microsoft.DotNet.ApiDiff.Tests.csproj @@ -1,7 +1,7 @@ - $(ToolsetTargetFramework) + $(SdkTargetFramework) Exe true diff --git a/test/Microsoft.DotNet.ApiSymbolExtensions.Tests/Microsoft.DotNet.ApiSymbolExtensions.Tests.csproj b/test/Microsoft.DotNet.ApiSymbolExtensions.Tests/Microsoft.DotNet.ApiSymbolExtensions.Tests.csproj index 9cb2cadbe2ed..01067804ffd4 100644 --- a/test/Microsoft.DotNet.ApiSymbolExtensions.Tests/Microsoft.DotNet.ApiSymbolExtensions.Tests.csproj +++ b/test/Microsoft.DotNet.ApiSymbolExtensions.Tests/Microsoft.DotNet.ApiSymbolExtensions.Tests.csproj @@ -1,8 +1,8 @@  - $(ToolsetTargetFramework);$(NetFrameworkToolCurrent) - Exe + $(SdkTargetFramework);$(NetFrameworkToolCurrent) + Exe true diff --git a/test/Microsoft.DotNet.Cli.Utils.Tests/Microsoft.DotNet.Cli.Utils.Tests.csproj b/test/Microsoft.DotNet.Cli.Utils.Tests/Microsoft.DotNet.Cli.Utils.Tests.csproj index 26b3ab5addb4..f1daf8fe9881 100644 --- a/test/Microsoft.DotNet.Cli.Utils.Tests/Microsoft.DotNet.Cli.Utils.Tests.csproj +++ b/test/Microsoft.DotNet.Cli.Utils.Tests/Microsoft.DotNet.Cli.Utils.Tests.csproj @@ -1,6 +1,6 @@  - $(ToolsetTargetFramework) + $(SdkTargetFramework) Exe MicrosoftAspNetCore diff --git a/test/Microsoft.DotNet.GenAPI.Tests/Microsoft.DotNet.GenAPI.Tests.csproj b/test/Microsoft.DotNet.GenAPI.Tests/Microsoft.DotNet.GenAPI.Tests.csproj index 82da898e0bb7..5fb5b54518a4 100644 --- a/test/Microsoft.DotNet.GenAPI.Tests/Microsoft.DotNet.GenAPI.Tests.csproj +++ b/test/Microsoft.DotNet.GenAPI.Tests/Microsoft.DotNet.GenAPI.Tests.csproj @@ -1,8 +1,8 @@  - $(ToolsetTargetFramework) - Exe + $(SdkTargetFramework) + Exe true diff --git a/test/Microsoft.DotNet.PackageInstall.Tests/Microsoft.DotNet.PackageInstall.Tests.csproj b/test/Microsoft.DotNet.PackageInstall.Tests/Microsoft.DotNet.PackageInstall.Tests.csproj index 83b6439cc8c8..e144b6210c57 100644 --- a/test/Microsoft.DotNet.PackageInstall.Tests/Microsoft.DotNet.PackageInstall.Tests.csproj +++ b/test/Microsoft.DotNet.PackageInstall.Tests/Microsoft.DotNet.PackageInstall.Tests.csproj @@ -7,7 +7,7 @@ - $(ToolsetTargetFramework) + $(SdkTargetFramework) Exe MicrosoftAspNetCore false diff --git a/test/Microsoft.DotNet.PackageValidation.Tests/Microsoft.DotNet.PackageValidation.Tests.csproj b/test/Microsoft.DotNet.PackageValidation.Tests/Microsoft.DotNet.PackageValidation.Tests.csproj index 2d126411c3e6..d9a65ec6e75d 100644 --- a/test/Microsoft.DotNet.PackageValidation.Tests/Microsoft.DotNet.PackageValidation.Tests.csproj +++ b/test/Microsoft.DotNet.PackageValidation.Tests/Microsoft.DotNet.PackageValidation.Tests.csproj @@ -1,8 +1,8 @@  - $(ToolsetTargetFramework);$(NetFrameworkToolCurrent) - Exe + $(SdkTargetFramework);$(NetFrameworkToolCurrent) + Exe true diff --git a/test/Microsoft.DotNet.TemplateLocator.Tests/Microsoft.DotNet.TemplateLocator.Tests.csproj b/test/Microsoft.DotNet.TemplateLocator.Tests/Microsoft.DotNet.TemplateLocator.Tests.csproj index 8875d0f3169b..06cc40d7fe5a 100644 --- a/test/Microsoft.DotNet.TemplateLocator.Tests/Microsoft.DotNet.TemplateLocator.Tests.csproj +++ b/test/Microsoft.DotNet.TemplateLocator.Tests/Microsoft.DotNet.TemplateLocator.Tests.csproj @@ -1,12 +1,12 @@  - net472;$(ToolsetTargetFramework) - $(ToolsetTargetFramework) + net472;$(SdkTargetFramework) + $(SdkTargetFramework) - $(ToolsetTargetFramework) - Exe + $(SdkTargetFramework) + Exe MicrosoftAspNetCore true diff --git a/test/trustedroots.Tests/trustedroots.Tests.csproj b/test/trustedroots.Tests/trustedroots.Tests.csproj index c4fd805c72af..ed864b10bf0b 100644 --- a/test/trustedroots.Tests/trustedroots.Tests.csproj +++ b/test/trustedroots.Tests/trustedroots.Tests.csproj @@ -2,7 +2,7 @@ - $(ToolsetTargetFramework) + $(SdkTargetFramework) Exe false From 95cd079fec40a2091539a8f73fb79484d6d26989 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Fri, 6 Mar 2026 18:24:36 +0000 Subject: [PATCH 2/3] Fix: Update Microsoft.NET.Build.Containers.csproj to reference renamed netframeworkDefinitions.cs Co-authored-by: marcpopMSFT <12663534+marcpopMSFT@users.noreply.github.com> --- .../Microsoft.NET.Build.Containers.csproj | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Containers/Microsoft.NET.Build.Containers/Microsoft.NET.Build.Containers.csproj b/src/Containers/Microsoft.NET.Build.Containers/Microsoft.NET.Build.Containers.csproj index d635d1fdfb86..97ff0e7306b9 100644 --- a/src/Containers/Microsoft.NET.Build.Containers/Microsoft.NET.Build.Containers.csproj +++ b/src/Containers/Microsoft.NET.Build.Containers/Microsoft.NET.Build.Containers.csproj @@ -77,7 +77,7 @@ - + @@ -87,7 +87,7 @@ - + From f897542a19c0eb71c24d5956add809f7549f0636 Mon Sep 17 00:00:00 2001 From: Marc Paine Date: Tue, 17 Mar 2026 13:34:44 -0700 Subject: [PATCH 3/3] Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> --- .../Microsoft.NET.Build.Containers.csproj | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/Containers/Microsoft.NET.Build.Containers/Microsoft.NET.Build.Containers.csproj b/src/Containers/Microsoft.NET.Build.Containers/Microsoft.NET.Build.Containers.csproj index 97ff0e7306b9..3c4c3d932e9b 100644 --- a/src/Containers/Microsoft.NET.Build.Containers/Microsoft.NET.Build.Containers.csproj +++ b/src/Containers/Microsoft.NET.Build.Containers/Microsoft.NET.Build.Containers.csproj @@ -65,8 +65,8 @@ - - + + @@ -84,8 +84,8 @@ - - + +