Skip to content

Change MaxParallelTestModulesOption to int #50548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 29, 2025
Merged

Change MaxParallelTestModulesOption to int #50548

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/Cli/dotnet/Commands/Test/TestingPlatformCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,8 @@ private void InitializeTestExecutionActionQueue(int degreeOfParallelism, TestOpt

private static int GetDegreeOfParallelism(ParseResult parseResult)
{
if (!int.TryParse(parseResult.GetValue(TestingPlatformOptions.MaxParallelTestModulesOption), out int degreeOfParallelism) || degreeOfParallelism <= 0)
var degreeOfParallelism = parseResult.GetValue(TestingPlatformOptions.MaxParallelTestModulesOption);
if (degreeOfParallelism <= 0)
degreeOfParallelism = Environment.ProcessorCount;
return degreeOfParallelism;
}
Expand Down
2 changes: 1 addition & 1 deletion src/Cli/dotnet/Commands/Test/TestingPlatformOptions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ internal static class TestingPlatformOptions
Arity = ArgumentArity.ExactlyOne
};

public static readonly Option<string> MaxParallelTestModulesOption = new("--max-parallel-test-modules")
public static readonly Option<int> MaxParallelTestModulesOption = new("--max-parallel-test-modules")
{
Description = CliCommandStrings.CmdMaxParallelTestModulesDescription,
HelpName = CliCommandStrings.CmdNumberName
Expand Down