Skip to content

Conversation

@mariam-abdulla
Copy link
Member

@mariam-abdulla mariam-abdulla commented Aug 29, 2025

This pull request refactors the handling of the --max-parallel-test-modules command-line option to improve type safety and simplify parsing logic. The most important changes are grouped below:

Command-line option type update:

  • Changed the type of MaxParallelTestModulesOption from Option<string> to Option<int> in TestingPlatformOptions, ensuring that the option value is parsed as an integer directly.

Parsing logic simplification:

  • Updated the GetDegreeOfParallelism method in TestingPlatformCommand.cs to remove manual string-to-int parsing, leveraging the new integer type for MaxParallelTestModulesOption. This also makes the logic clearer and less error-prone.

Fixes #50526

@Youssef1313 Youssef1313 merged commit 3afdcd1 into release/10.0.1xx Aug 29, 2025
27 checks passed
@Youssef1313 Youssef1313 deleted the dev/mabdullah/set-MaxParallelTestModulesOption-to-int branch August 29, 2025 10:51
@Youssef1313 Youssef1313 linked an issue Aug 29, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MaxParallelTestModulesOption should be int, not string

3 participants