Fix updating globaljsonworkloadsets.json
#50372
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current logic sets the file stream position to 0, and overwrites the content of the
globaljsonworkloadsets.jsonfile.If the new content is shorter, then some characters remain from the old content, thus making the JSON malformed.
Example
workloadVersioninglobal.jsonto9.0.303.1.dotnet workload restoremakes the content ofglobaljsonworkloadsets.jsonthe following:{ "path-to-global-json": "9.0.303.1" }workloadVersioninglobal.jsonto9.0.304.dotnet workload restoremakes the content ofglobaljsonworkloadsets.jsonthe following:{ "path-to-global-json": "9.0.304" } }The new version number is 2 characters shorter, so 2 characters from the old content of the file remains.
This is not a valid JSON and causes any subsequent
dotnet workload restorecommand to fail.Fix
This fix sets the stream length to 0, truncating the stream, so there will be no remainder of the old content.
Also, as per
SetLengthdocumentation:if the current position is greater than the new length, the current position is moved to the last byte of the stream, soSeekis unnecessary.