Copy files for MSI layout from the post-crossgen'd location #49096
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes internal issue reported where the .NET 10.0.100 Preview 4 SDK didn't have R2Rd Roslyn in the Exe/Msi installers.
Contributor
There was a problem hiding this comment.
Pull Request Overview
Updates the installer layout to pull SDK files from the post-crossgen output location rather than the default build output, ensuring R2Rd Roslyn is included in MSI installers.
- Switches the
SdkOutputFileitem’s source from$(OutputPath)to$(InstallerOutputDirectory)
Comments suppressed due to low confidence (1)
src/Layout/redist/targets/GenerateInstallerLayout.targets:97
- Consider adding an explicit directory separator before the wildcard (e.g.,
$(InstallerOutputDirectory)\\**\\*) to ensure correct path resolution regardless of whetherInstallerOutputDirectoryends with a slash.
<SdkOutputFile Include="$(InstallerOutputDirectory)**\\*" />
jkoritzinsky
added a commit
to dotnet/dotnet
that referenced
this pull request
May 21, 2025
…rossgen'd location Fixes internal issue reported where the .NET 10.0.100 Preview 4 SDK didn't have R2Rd Roslyn in the Exe/Msi installers. Main PR at dotnet/sdk#49096
3 tasks
ViktorHofer
approved these changes
May 22, 2025
Member
ViktorHofer
left a comment
ViktorHofer
left a comment
There was a problem hiding this comment.
Damn, my fault. Thanks for fixing.
Member
|
@jkoritzinsky I pushed a commit to your branch as the target dependson was now incorrect. Shouldn't need a backport into P5 though. This is a correctness thing only. |
Member
|
Failures are unrelated. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes internal issue reported where the .NET 10.0.100 Preview 4 SDK didn't have R2Rd Roslyn in the Exe/Msi installers.