Skip to content

Default JsonSerializerIsReflectionEnabledByDefault to true on Blazor WASM. #31909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lewing merged 2 commits into from
Apr 20, 2023
Merged

Default JsonSerializerIsReflectionEnabledByDefault to true on Blazor WASM. #31909

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2bd5619
Default JsonSerializerIsReflectionEnabledByDefault to true on Blazor …
eerhardt Apr 20, 2023
81f4769
Update src/BlazorWasmSdk/Targets/Microsoft.NET.Sdk.BlazorWebAssembly.…
eerhardt Apr 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/BlazorWasmSdk/Targets/Microsoft.NET.Sdk.BlazorWebAssembly.Current.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@ Copyright (c) .NET Foundation. All rights reserved.
<!-- Trimmer defaults that depend on user-definable settings.
This must be configured before it's initialized in the .NET SDK targets (which are imported by the Razor SDK). -->
<SuppressTrimAnalysisWarnings Condition="'$(SuppressTrimAnalysisWarnings)' == '' And '$(TrimmerDefaultAction)' != 'link'">true</SuppressTrimAnalysisWarnings>

<!-- Similarly these feature switches must be configured before they are initialized in imported SDKs -->
<JsonSerializerIsReflectionEnabledByDefault Condition="'$(JsonSerializerIsReflectionEnabledByDefault)' == ''">true</JsonSerializerIsReflectionEnabledByDefault>
Copy link
Member

@eiriktsarpalis eiriktsarpalis Apr 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need any testing?

Copy link
Member Author

@eerhardt eerhardt Apr 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the note in the top comment.

NOTE: I don't know how to test this at this layer. If anyone has a good recommendation for how to test it, I am open to suggestions.

Copy link
Member

@maraf maraf Apr 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK blazor apps don't run here. So best way to test it is to locally run blazor app with the built SDK.

Copy link
Member

@javiercn javiercn Apr 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can't be disabled for blazor apps, if the user disables this, we should emit an error instead in the context of blazor webassembly apps or simply ignore the user choice.

The framework is dependent on this feature for basic functionality (JS interop)

</PropertyGroup>

<Import Sdk="Microsoft.NET.Sdk.Razor" Project="Sdk.targets" />
Expand Down