Bundle Source Link packages #31632
Merged
Bundle Source Link packages #31632
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.SourceLink.props
Outdated
Show resolved
Hide resolved
tmat
force-pushed
the
SourceLinkSdk
branch
2 times, most recently
from
ee262cb to
1797771
Compare
dsplaisted
approved these changes
Apr 7, 2023
Member
dsplaisted
left a comment
dsplaisted
left a comment
There was a problem hiding this comment.
I haven't looked at the code for each sourcelink package, so I'm assuming those are good to be integrated into the SDK.
Once this flows into dotnet/installer, we should check to see whether the sourcelink SDKs are appropriately crossgen'd.
src/Assets/TestProjects/SourceLinkTestApp/SourceLinkTestApp.csproj
Outdated
Show resolved
Hide resolved
src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.SourceLink.props
Outdated
Show resolved
Hide resolved
src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.SourceLink.targets
Outdated
Show resolved
Hide resolved
tmat
force-pushed
the
SourceLinkSdk
branch
3 times, most recently
from
fa8b410 to
9bf222c
Compare
5 tasks
Microsoft.NET.Sdk.Common.targets is imported from Solution.targets but corresponding props file isn't, which breaks the targets.
dsplaisted
approved these changes
Apr 14, 2023
src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.SourceLink.props
Outdated
Show resolved
Hide resolved
3 tasks
This was referenced Aug 2, 2023
baronfel
added
the
breaking-change
|
Added When you commit this breaking change:
Tagging @dotnet/compat for awareness of the breaking change. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Source Link targets are included automatically unless the project has already a
PackageReferenceto any Source Link package.Property
SuppressImplicitGitSourceLinkcan be used to disable automatic inclusion of Source Link.