Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor source build tests to used common extracted sdk #44568

Merged
merged 2 commits into from
Nov 1, 2024
Merged

Refactor source build tests to used common extracted sdk #44568

merged 2 commits into from
Nov 1, 2024

Conversation

MichaelSimons
Copy link
Member

@MichaelSimons MichaelSimons requested review from a team as code owners October 31, 2024 22:01
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Request triage from a team member labels Oct 31, 2024
mthalman
mthalman reviewed Nov 1, 2024
View reviewed changes
Copy link
Member

@mthalman mthalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should also be able to be updated to use the extracted directory instead:

sdk/src/SourceBuild/content/test/Microsoft.DotNet.SourceBuild.Tests/SourceBuiltArtifactsTests.cs

Line 59 in 4694a5b

Utilities.ExtractTarball(Config.SdkTarballPath ?? string.Empty, outputDir, "./sdk/*/.version");

@MichaelSimons
Copy link
Member Author

MichaelSimons commented Nov 1, 2024 •
edited
Loading

This should also be able to be updated to use the extracted directory instead:

sdk/src/SourceBuild/content/test/Microsoft.DotNet.SourceBuild.Tests/SourceBuiltArtifactsTests.cs

Line 59 in 4694a5b

Utilities.ExtractTarball(Config.SdkTarballPath ?? string.Empty, outputDir, "./sdk/*/.version");

That should have been using the sdk DotNetHelper sets up in the first place. Will fix.

@MichaelSimons
Copy link
Member Author

This should also be able to be updated to use the extracted directory instead:

sdk/src/SourceBuild/content/test/Microsoft.DotNet.SourceBuild.Tests/SourceBuiltArtifactsTests.cs

Line 59 in 4694a5b

Utilities.ExtractTarball(Config.SdkTarballPath ?? string.Empty, outputDir, "./sdk/*/.version");

That should have been using the sdk DotNetHelper sets up in the first place. Will fix.

Fixed in d0c5be6

@MichaelSimons MichaelSimons merged commit be243d5 into dotnet:main Nov 1, 2024
37 checks passed
@MichaelSimons MichaelSimons deleted the tests-extracted-sdk branch November 1, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NikolaMilosavljevic NikolaMilosavljevic NikolaMilosavljevic approved these changes

@mthalman mthalman mthalman approved these changes

Assignees
No one assigned
Labels
Area-Infrastructure untriaged Request triage from a team member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Smoke tests should reuse common extracted SDK location
3 participants
@MichaelSimons @NikolaMilosavljevic @mthalman