Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.NET global tools should have testing for creating a signed apphost on Mac #19463

Open
agocke opened this issue Aug 2, 2021 · 7 comments
Open
Assignees
Milestone

Comments

@agocke
Copy link
Member

agocke commented Aug 2, 2021

dotnet/runtime#52335 tracked signing as part of CreateAppHost. Global tools now need to test the end-to-end scenario and validate multi-arch support.

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-External untriaged Request triage from a team member labels Aug 2, 2021
@wli3 wli3 removed the untriaged Request triage from a team member label Aug 6, 2021
@wli3 wli3 added this to the Discussion milestone Aug 6, 2021
@wli3
Copy link

wli3 commented Aug 6, 2021

Not sure it is the right layer. Global tools call the same API as building a project. Did I use the wrong API layer? I was expecting runtime can completely abstract it away from SDK layer.

Global tools does few end to end tests. But we don't have manual test on arm64 mac as well as arm64 CI machine. It is mostly ok by relying on the runtime abstraction for few years without a problem. But we might need to revisit it. I won't anticipate it is easy considering there is only one person have arm64 machine in the team.

@agocke
Copy link
Member Author

agocke commented Aug 7, 2021

@wli3 This issue is just tracking validation that it works. I expect that it works, but haven't tried it, and we don't have tests for global tools either.

@wli3
Copy link

wli3 commented Aug 9, 2021

@agocke on runtime layer it should not be testing for global tools. It should be tests for apphost creation on all platforms

@agocke
Copy link
Member Author

agocke commented Aug 9, 2021

We already have those, so if you think standard apphost creation is good enough testing for global tools as well, feel free to close this issue.

@wli3 wli3 closed this as completed Aug 9, 2021
@agocke
Copy link
Member Author

agocke commented Sep 24, 2021

Reopening as it looks like #21349 confirms that it doesn't work.

@agocke agocke reopened this Sep 24, 2021
@vitek-karas
Copy link
Member

I think we need end-to-end testing for tools - install, run, uninstall. Which might already exist, but the problem is that as far as I know SDK repo doesn't run anything on osx-arm64, which is the affected architecture (as it requires signing).

@agocke
Copy link
Member Author

agocke commented Sep 24, 2021

Mac-arm64 does have stronger default requirements for signing, but we should also be able to observe the problem on macos-x64 manually.

@wli3 wli3 assigned joeloff and unassigned wli3 Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants