drop a binlog

Author: baronfel

test/Microsoft.NET.Publish.Tests/GivenThatWeWantToPublishAToolProject.cs

@@ -49,10 +49,14 @@ public void It_can_publish_and_has_apphost()
         // PackTool.targets
         public void It_can_publish_selfcontained_and_has_apphost()
         {
-            var testAsset = SetupTestAsset();
+            var testAsset = SetupTestAsset().SetProjProperty("PublishSelfContained", "true");
             var publishCommand = new PublishCommand(testAsset);
 
-            publishCommand.WithWorkingDirectory(testAsset.Path).Execute("-bl", "-p", "PublishSelfContained=true");
+            var binlogDestPath = Environment.GetEnvironmentVariable("HELIX_WORKITEM_UPLOAD_ROOT") is { } ciOutputRoot ?
+                Path.Combine(ciOutputRoot, "binlog", $"{nameof(It_can_publish_selfcontained_and_has_apphost)}.binlog") :
+                "./msbuild.binlog";
+
+            publishCommand.WithWorkingDirectory(testAsset.Path).Execute($"-bl:{binlogDestPath}");
 
             publishCommand.GetOutputDirectory(targetFramework: ToolsetInfo.CurrentTargetFramework, runtimeIdentifier: System.Runtime.InteropServices.RuntimeInformation.RuntimeIdentifier)
                 .Should().HaveFile("consoledemo" + Constants.ExeSuffix)

test/Microsoft.NET.TestFramework/TestAsset.cs

@@ -60,6 +60,10 @@ internal void FindProjectFiles()
             }
         }
 
+        /// <summary>
+        ///  Copies all of the source code from the TestAsset's original location to the previously-configured destination directory.
+        /// </summary>
+        /// <returns></returns>
         public TestAsset WithSource()
         {
             _projectFiles = new List<string>();
@@ -131,6 +135,20 @@ public TestAsset UpdateProjProperty(string propertyName, string variableName, st
             });
         }
 
+        public TestAsset SetProjProperty(string propertyName, string value)
+        {
+            return WithProjectChanges(
+            p =>
+            {
+                if (p.Root is not null)
+                {
+                    var ns = p.Root.Name.Namespace;
+                    var pg = p.Root.Elements(ns + "PropertyGroup").First();
+                    pg.Add(new XElement(ns + propertyName, value));
+                }
+            });
+        }
+
         public TestAsset ReplacePackageVersionVariable(string targetName, string targetValue)
         {
             var elementsWithVersionAttribute = new[] { "PackageReference", "Package", "Sdk" };

test/Microsoft.NET.TestFramework/TestAssetsManager.cs

@@ -27,6 +27,10 @@ public TestAssetsManager(ITestOutputHelper log)
             TestAssetsRoot = testAssetsDirectory;
         }
 
+        /// <summary>
+        /// Creates a new 'bubble' for the given test asset project in a subdirectory
+        /// of the current test execution context, scoped by the calling method and optional unique identifier.
+        /// </summary>
         public TestAsset CopyTestAsset(
             string testProjectName,
             [CallerMemberName] string callingMethod = "",