Fix TensorPrimitives.Abs for 0 for signed integers #97820
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was erroneously throwing an exception intended only for the minimum value of a signed integer.
ghost
added
the
|
Tagging subscribers to this area: @dotnet/area-system-numerics Issue DetailsIt was erroneously throwing an exception intended only for the minimum value of a signed integer. I found this when adding in vectorization support for Ts with sizeof(t) < 4, as tests failed, so the tests for this are forthcoming with that change.
|
tannergooding
approved these changes
Feb 1, 2024
This was referenced Feb 1, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was erroneously throwing an exception intended only for the minimum value of a signed integer.
I found this when adding in vectorization support for Ts with sizeof(t) < 4, as tests failed, so the tests for this are forthcoming with that change.