Support VMR cross arch build #95425
Merged
Support VMR cross arch build #95425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
needs-area-label
This was referenced Nov 29, 2023
Member
Author
|
/azp run runtime-community |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jkoritzinsky
approved these changes
Dec 1, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make runtime compatible with cross-arch compilation, we should add --cross to the inner source-build build when building a cross-arch VMR vertical and avoid publishing anything ReadyToRun or AOT compiled. The compilers don't have a valid runtime pack for the host during the crossbuild at this point, so trying to run them fails.
Part of dotnet/source-build#3698
Redo of #95088, but compares architecture instead of RID for passing --cross, and checks for DotnetBuildVertical instead of DotnetBuildFromSource to disable crossgen and ilc.