Skip to content

Fix propagating cmake exit code from gen-buildsys.sh #95408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
akoeplinger wants to merge 2 commits into from
Closed

Fix propagating cmake exit code from gen-buildsys.sh #95408

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1e8340f
Fix propagating cmake exit code from gen-buildsys.sh
akoeplinger Nov 29, 2023
0771386
Use -S and -B flags instead
akoeplinger Nov 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions eng/native/gen-buildsys.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,16 +104,14 @@ if [[ "$host_arch" == "wasm" ]]; then
fi
fi

# We have to be able to build with CMake 3.6.2, so we can't use the -S or -B options
pushd "$2"

$cmake_command \
--no-warn-unused-cli \
-G "$generator" \
"-DCMAKE_BUILD_TYPE=$buildtype" \
"-DCMAKE_INSTALL_PREFIX=$__CMakeBinDir" \
$cmake_extra_defines \
$__UnprocessedCMakeArgs \
"$1"
-S "$1" \
-B "$3"

popd
exit $?
Copy link
Member Author

@akoeplinger akoeplinger Nov 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still keeping this so it's clearer for the next person touching this line that the exit code is important