-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Skip duplicate --info output if it is known SDK output #91900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov Issue DetailsFixes dotnet/sdk#35237 cc @tmds
|
vitek-karas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume we'll add a test for this in the SDK repo once it flows there (would be nice to have a test which validates that we do print out a RID - always.
Co-authored-by: Vitek Karas <[email protected]>
That was what I was thinking, but looking at it again, I think something in here makes more sense. I'll look at adding something to check the host output includes a RID with no SDK and doesn't with a mocked SDK. |
|
/backport to release/8.0 |
|
Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/6175745936 |
Fixes dotnet/sdk#35237
cc @tmds