Skip to content

Conversation

@elinor-fung
Copy link
Member

@ghost
Copy link

ghost commented Sep 11, 2023

Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes dotnet/sdk#35237

cc @tmds

Author: elinor-fung
Assignees: -
Labels:

area-Host

Milestone: -

Copy link
Member

@vitek-karas vitek-karas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume we'll add a test for this in the SDK repo once it flows there (would be nice to have a test which validates that we do print out a RID - always.

@elinor-fung
Copy link
Member Author

I assume we'll add a test for this in the SDK repo once it flows there

That was what I was thinking, but looking at it again, I think something in here makes more sense. I'll look at adding something to check the host output includes a RID with no SDK and doesn't with a mocked SDK.

@elinor-fung elinor-fung merged commit 32d2bcd into dotnet:main Sep 13, 2023
@elinor-fung elinor-fung deleted the skipSdkInfoOutput branch September 13, 2023 17:19
@elinor-fung
Copy link
Member Author

/backport to release/8.0

@github-actions
Copy link
Contributor

@ghost ghost locked as resolved and limited conversation to collaborators Oct 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dotnet --info includes two RID values with .NET 8

2 participants