Ignore some tests on macOS only due to small stack size #90116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsRationale: #87879 (comment)
|
|
/azp list |
This comment was marked as resolved.
This comment was marked as resolved.
|
/azp run runtime-coreclr outerloop, runtime-coreclr jitstress, runtime-coreclr pgostress |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run runtime-coreclr outerloop, runtime-coreclr jitstress, runtime-coreclr pgostress |
|
Azure Pipelines successfully started running 3 pipeline(s). |
This was referenced Aug 8, 2023
|
@jkotas @jakobbotsch PTAL - this PR doesn't "resolve" #87879 but there is no need in disabling the tests for all platforms when only mac is affected |
jkotas
approved these changes
Aug 8, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale: #87879 (comment)
This PR enables these tests back on non-macOS platforms + disables HugeArray1 on macOS since it hits the same issue too (e.g. in https://github.com/dotnet/runtime/runs/15626705312)