From 9aa8c32e8bbe3a4a6ee8a03aa3453f601e6f1ec9 Mon Sep 17 00:00:00 2001 From: Adeel Mujahid <3840695+am11@users.noreply.github.com> Date: Sun, 26 Mar 2023 11:26:03 +0300 Subject: [PATCH 1/2] Upgrade arm64 cross image to Ubuntu 22.04 / llvm-15 --- eng/pipelines/common/templates/pipeline-with-resources.yml | 2 +- .../Microsoft.NETCore.App.Crossgen2.sfxproj | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/eng/pipelines/common/templates/pipeline-with-resources.yml b/eng/pipelines/common/templates/pipeline-with-resources.yml index e849da704781c..40df1ebb72703 100644 --- a/eng/pipelines/common/templates/pipeline-with-resources.yml +++ b/eng/pipelines/common/templates/pipeline-with-resources.yml @@ -15,7 +15,7 @@ resources: ROOTFS_DIR: /crossrootfs/armv6 - container: linux_arm64 - image: mcr.microsoft.com/dotnet-buildtools/prereqs:ubuntu-20.04-cross-arm64 + image: mcr.microsoft.com/dotnet-buildtools/prereqs:ubuntu-22.04-cross-arm64 env: ROOTFS_DIR: /crossrootfs/arm64 diff --git a/src/installer/pkg/sfx/Microsoft.NETCore.App/Microsoft.NETCore.App.Crossgen2.sfxproj b/src/installer/pkg/sfx/Microsoft.NETCore.App/Microsoft.NETCore.App.Crossgen2.sfxproj index 0f75f74dbc583..ad428b5a42a1c 100644 --- a/src/installer/pkg/sfx/Microsoft.NETCore.App/Microsoft.NETCore.App.Crossgen2.sfxproj +++ b/src/installer/pkg/sfx/Microsoft.NETCore.App/Microsoft.NETCore.App.Crossgen2.sfxproj @@ -22,8 +22,7 @@ false false - llvm-objcopy-15 - aarch64-linux-gnu-objcopy + llvm-objcopy-15 Date: Sun, 26 Mar 2023 11:48:53 +0300 Subject: [PATCH 2/2] Remove compilerArg for clang --- .../templates/runtimes/build-test-job.yml | 19 +------------------ .../coreclr/templates/build-jit-job.yml | 12 +----------- eng/pipelines/coreclr/templates/build-job.yml | 2 -- 3 files changed, 2 insertions(+), 31 deletions(-) diff --git a/eng/pipelines/common/templates/runtimes/build-test-job.yml b/eng/pipelines/common/templates/runtimes/build-test-job.yml index f5f306713fc8e..644b873554b0a 100644 --- a/eng/pipelines/common/templates/runtimes/build-test-job.yml +++ b/eng/pipelines/common/templates/runtimes/build-test-job.yml @@ -36,11 +36,7 @@ jobs: testGroup: ${{ parameters.testGroup }} pool: ${{ parameters.pool }} dependOnEvaluatePaths: ${{ parameters.dependOnEvaluatePaths }} - - ${{ if and(ne(parameters.osGroup, 'windows'), ne(parameters.compilerName, 'gcc'), not(and(eq(parameters.osGroup, 'linux'), eq(parameters.osSubgroup, '_musl'))), not(eq(parameters.osGroup, 'osx'))) }}: - compilerArg: '-clang9' - ${{ if not(and(ne(parameters.osGroup, 'windows'), ne(parameters.compilerName, 'gcc'), not(and(eq(parameters.osGroup, 'linux'), eq(parameters.osSubgroup, '_musl'))), not(eq(parameters.osGroup, 'osx')))) }}: - compilerArg: '' + compilerArg: '' # Test jobs should continue on error for internal builds ${{ if eq(variables['System.TeamProject'], 'internal') }}: @@ -72,19 +68,6 @@ jobs: - ${{ variable }} - name: liveRuntimeBuildParams value: 'libs.sfx+libs.oob+clr.iltools /p:RefOnly=true -c Release -ci' - - name: compilerArg - value: '' - - ${{ if and(ne(parameters.osGroup, 'windows'), ne(parameters.compilerName, 'gcc')) }}: - - name: compilerArg - value: '-clang9' - # We need to use the stable version available on Alpine Linux - - ${{ if and(eq(parameters.osGroup, 'linux'), eq(parameters.osSubgroup, '_musl')) }}: - - name: compilerArg - value: '' - # AppleClang has different version scheme, so we let compiler introspection pick up the available clang from PATH - - ${{ if eq(parameters.osGroup, 'osx') }}: - - name: compilerArg - value: '' - name: runtimeFlavorArgs value: '' diff --git a/eng/pipelines/coreclr/templates/build-jit-job.yml b/eng/pipelines/coreclr/templates/build-jit-job.yml index 8aeaa489f9b1d..d80e5ac98b882 100644 --- a/eng/pipelines/coreclr/templates/build-jit-job.yml +++ b/eng/pipelines/coreclr/templates/build-jit-job.yml @@ -51,19 +51,9 @@ jobs: - name: uploadAs value: ${{ parameters.uploadAs }} + # let the init-compiler script select the correct compiler (we only override it for -gcc in other places) - name: compilerArg value: '' - - ${{ if ne(parameters.osGroup, 'windows') }}: - - name: compilerArg - value: '-clang9' - # We need to use the stable version available on Alpine Linux - - ${{ if and(eq(parameters.osGroup, 'linux'), eq(parameters.osSubgroup, '_musl')) }}: - - name: compilerArg - value: '' - # AppleClang has different version scheme, so we let compiler introspection pick up the available clang from PATH - - ${{ if eq(parameters.osGroup, 'osx') }}: - - name: compilerArg - value: '' - ${{ if eq(parameters.osGroup, 'windows') }}: - name: PythonScript diff --git a/eng/pipelines/coreclr/templates/build-job.yml b/eng/pipelines/coreclr/templates/build-job.yml index a7f68e3422055..74094e011732e 100644 --- a/eng/pipelines/coreclr/templates/build-job.yml +++ b/eng/pipelines/coreclr/templates/build-job.yml @@ -87,8 +87,6 @@ jobs: - name: publishLogsArtifactPrefix value: 'BuildLogs_CoreCLR_GCC' - ${{ if and(ne(parameters.osGroup, 'windows'), ne(parameters.compilerName, 'gcc')) }}: - - name: compilerArg - value: '-clang9' # We need to use the stable version available on Alpine Linux - ${{ if and(eq(parameters.osGroup, 'linux'), eq(parameters.osSubgroup, '_musl')) }}: - name: compilerArg