From 1c629b3c28f99f75cfb8c9b65593169e7ebcd85e Mon Sep 17 00:00:00 2001 From: Ankit Jain Date: Tue, 3 Jan 2023 18:00:29 +0000 Subject: [PATCH 1/2] [wasm] Revert back to using latest stable versions of chrome for testing --- eng/testing/ProvisioningVersions.props | 4 +++- src/tasks/WasmBuildTasks/GetChromeVersions.cs | 3 ++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/eng/testing/ProvisioningVersions.props b/eng/testing/ProvisioningVersions.props index 6a2141e27ccd0..b4b8f8ca1f75f 100644 --- a/eng/testing/ProvisioningVersions.props +++ b/eng/testing/ProvisioningVersions.props @@ -39,7 +39,7 @@ Refer to `GetChromeVersions` task in `src/tasks` to see how we find these snapshot urls. - --> + 107.0.5304.110 1047731 @@ -51,6 +51,8 @@ <_ChromeBaseSnapshotUrl>https://storage.googleapis.com/chromium-browser-snapshots/Win_x64/1047737 + --> + 108.0.1 https://ftp.mozilla.org/pub/firefox/releases/$(FirefoxRevision)/linux-x86_64/en-US/firefox-$(FirefoxRevision).tar.bz2 diff --git a/src/tasks/WasmBuildTasks/GetChromeVersions.cs b/src/tasks/WasmBuildTasks/GetChromeVersions.cs index 81a65abb6bd8a..37d6f214bf81e 100644 --- a/src/tasks/WasmBuildTasks/GetChromeVersions.cs +++ b/src/tasks/WasmBuildTasks/GetChromeVersions.cs @@ -103,7 +103,8 @@ private async Task GetChromeUrlsAsync(ChromeVersionSpec version) throw new LogAsErrorException($"Could not find a chrome snapshot folder under {baseUrl}, " + $"for branch positions {version.branch_base_position} to " + - $"{branchPosition}, for version {version.version}."); + $"{branchPosition}, for version {version.version}. " + + "A fixed version+url can be set in eng/testing/ProvisioningVersions.props ."); } private async Task GetChromeVersionAsync() From 926a0cd4ac4b09fe24b217d9100e079046178f02 Mon Sep 17 00:00:00 2001 From: Ankit Jain Date: Tue, 3 Jan 2023 19:14:03 +0000 Subject: [PATCH 2/2] [wasm] widen the search area for chrome snapshots. They seem to be less frequent for windows builds. --- src/tasks/WasmBuildTasks/GetChromeVersions.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/tasks/WasmBuildTasks/GetChromeVersions.cs b/src/tasks/WasmBuildTasks/GetChromeVersions.cs index 37d6f214bf81e..4eb128bb771e6 100644 --- a/src/tasks/WasmBuildTasks/GetChromeVersions.cs +++ b/src/tasks/WasmBuildTasks/GetChromeVersions.cs @@ -22,7 +22,7 @@ public class GetChromeVersions : MBU.Task private const string s_allJsonUrl = "http://omahaproxy.appspot.com/all.json"; private const string s_snapshotBaseUrl = $"https://storage.googleapis.com/chromium-browser-snapshots"; private const int s_versionCheckThresholdDays = 3; - private const int s_numBranchPositionsToTry = 30; + private const int s_numBranchPositionsToTry = 50; private static readonly HttpClient s_httpClient = new(); public string Channel { get; set; } = "stable";